Delegate value reading to ConfigVariableContent#8
Merged
prachigauriar merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
- Extract value fetching, watching, and encoding logic from
ConfigVariableReader into a new ConfigVariableContent type that
describes how each ConfigVariable maps to and from ConfigContent
primitives. This separates the “what type is this value” concern
from the reader’s get/fetch/watch orchestration.
- Add CodableValueRepresentation for JSON and property list values
- Add ConfigVariableDecodingFailedEvent for telemetry on decode errors
- Add accessors for RawRepresentable and RawRepresentable
values, as well as ExpressibleByConfigInt and
ExpressibleByConfigString
- Remove completed Architecture Plan and Implementation Plan docs
prachigauriar
force-pushed
the
prachi/config-variable-content
branch
from
6f09b48 to
569d434
Compare
Code Coverage ReportOverall Coverage: 99.78% (1,778 of 1,782) DevConfiguration: 99.78% (1,778 of 1,782)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigVariableReader into a new ConfigVariableContent type that
describes how each ConfigVariable maps to and from ConfigContent
primitives. This separates the “what type is this value” concern
from the reader’s get/fetch/watch orchestration.
values, as well as ExpressibleByConfigInt and
ExpressibleByConfigString