StructuredConfigReader First Slice — Define and Access Variables, Basic Telemetry#4
Merged
prachigauriar merged 33 commits intomainfrom Feb 17, 2026
Merged
Conversation
…on from DevFoundation
…olidate behavior in StructuredConfigReader
- DidAccessVariableBusEvent: posted when a variable is successfully accessed - DidFailToAccessVariableBusEvent: posted when a variable can't be found (.success(nil)) or if an error is raised when querying providers (.failure(error))
- Use the convenience initializer w/ EventBus parameter to get the standard TelemetryAccessReporter - Use the primary initializer to pass an access reporter type directly.
Code Coverage ReportOverall Coverage: 100.00% (325 of 325) DevConfiguration: 100.00% (325 of 325)
|
Sources/DevConfiguration/Telemetry/DidAccessVariableBusEvent.swift
Outdated
Show resolved
Hide resolved
Sources/DevConfiguration/Telemetry/DidAccessVariableBusEvent.swift
Outdated
Show resolved
Hide resolved
Sources/DevConfiguration/Telemetry/DidAccessConfigVariableEvent.swift
Outdated
Show resolved
Hide resolved
Sources/DevConfiguration/Telemetry/DidFailToAccessVariableBusEvent.swift
Outdated
Show resolved
Hide resolved
- Rename to DidAccessConfigVariableEvent and DidFailToAccessConfigVariableEvent - Provide the key as `AbsoluteConfigKey` rather than `String` - Provide the value as `ConfigValue` rather than `ConfigContent`
7169eda to
76c228e
Compare
prachigauriar
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
variables that packages key, default value, and VariableSecrecy
in a single type
ConfigReader with type-safe access, secrecy-aware queries, and
always-return semantics that return default values on error.
posts configuration access events to EventBus:
with key, value, and providerName
with key and error