Change ConfigVariableReader from a struct to a class#10
Merged
prachigauriar merged 1 commit intomainfrom Mar 6, 2026
Merged
Conversation
- Add a private MutableState struct to hold mutable state behind a
Mutex, making ConfigVariableReader Sendable. This enables variable
registration after the reader has been shared with other components.
- Mark ConfigVariableReader as a final class and add a computed
registeredVariables property that reads through the mutex.
- Change register from a mutating function to a non-mutating one that
writes through the mutex.
Code Coverage ReportOverall Coverage: 99.58% (1,887 of 1,895) DevConfiguration: 99.58% (1,887 of 1,895)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mutex, making ConfigVariableReader Sendable. This enables variable
registration after the reader has been shared with other components.
registeredVariables property that reads through the mutex.
writes through the mutex.