fix(screenshot tests): Fix screenshot tests antialiasing issue#967
Merged
VasilyStrelyaev merged 2 commits intoJun 23, 2025
Merged
Conversation
ajivanyandev
force-pushed
the
fix/screenshot-tests-trashhold-fix
branch
from
fc31f59 to
3b9f2ea
Compare
Contributor
Author
|
We may need to update the screenshot comparer library for more advanced functionality In the future. A little problematic to integrate a new library, when I can't run the tests locally, and having to run ci for every change. For now, based on research, decided to go with generally acceptable thresholds in testing practices. This fixes anti-aliasing problems. |
ajivanyandev
changed the title
ajivanyandev
changed the title
VasilyStrelyaev
previously approved these changes
Jun 11, 2025
VasilyStrelyaev
previously approved these changes
Jun 13, 2025
* replace create-react-app by create-vite for creating React App template --------- Co-authored-by: Vasily Strelyaev <Vasily.Strelyaev@devexpress.com>
VasilyStrelyaev
force-pushed
the
fix/screenshot-tests-trashhold-fix
branch
from
3b9f2ea to
5cdd406
Compare
VasilyStrelyaev
approved these changes
Jun 19, 2025
dxvladislavvolkov
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.