Skip to content

Conversation

@dmirgaev
Copy link
Contributor

No description provided.

@dmirgaev dmirgaev requested a review from a team as a code owner January 15, 2026 11:28
Copilot AI review requested due to automatic review settings January 15, 2026 11:28
@dmirgaev dmirgaev added the 26_1 label Jan 15, 2026
@dmirgaev dmirgaev self-assigned this Jan 15, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes overlapping issues between group rows and total summary in DataGrid by adjusting background-color properties for sticky columns across all themes.

Changes:

  • Changed background-color: transparent to background-color: inherit for sticky columns in group rows across all three themes (material, generic, fluent)
  • Inverted the CSS selector logic in the base gridBase file for total footer to apply background-color: transparent to non-sticky columns instead of sticky columns

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/devextreme-scss/scss/widgets/material/dataGrid/_index.scss Changed sticky group cell background from transparent to inherit
packages/devextreme-scss/scss/widgets/generic/dataGrid/_index.scss Changed sticky group cell background from transparent to inherit
packages/devextreme-scss/scss/widgets/fluent/dataGrid/_index.scss Changed sticky group cell background from transparent to inherit
packages/devextreme-scss/scss/widgets/base/_gridBase.scss Inverted selector to apply transparent background to non-sticky columns in total footer


.dx-#{$widget-name}-total-footer {
.dx-#{$widget-name}-sticky-column, .dx-#{$widget-name}-sticky-column-left, .dx-#{$widget-name}-sticky-column-right {
td:not(.dx-#{$widget-name}-sticky-column, .dx-#{$widget-name}-sticky-column-left, .dx-#{$widget-name}-sticky-column-right) {
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS :not() pseudo-class with multiple selectors separated by commas is not supported in older browsers and will only match elements that don't match ANY of the listed selectors (rather than all of them). This should use separate :not() pseudo-classes chained together: td:not(.dx-#{$widget-name}-sticky-column):not(.dx-#{$widget-name}-sticky-column-left):not(.dx-#{$widget-name}-sticky-column-right)

Suggested change
td:not(.dx-#{$widget-name}-sticky-column, .dx-#{$widget-name}-sticky-column-left, .dx-#{$widget-name}-sticky-column-right) {
td:not(.dx-#{$widget-name}-sticky-column):not(.dx-#{$widget-name}-sticky-column-left):not(.dx-#{$widget-name}-sticky-column-right) {

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant