Skip to content

Conversation

@chaosmirage
Copy link
Contributor

@chaosmirage chaosmirage commented Jan 14, 2026

This PR should be completed after #32047.

@chaosmirage chaosmirage force-pushed the feat/migrate-devextreme-to-nx-part-2 branch 4 times, most recently from d06eb22 to aa3431d Compare January 15, 2026 13:17
@chaosmirage chaosmirage force-pushed the feat/migrate-devextreme-to-nx-part-2 branch from 0c4f0e9 to de4bf99 Compare January 15, 2026 15:21
@chaosmirage chaosmirage self-assigned this Jan 15, 2026
@chaosmirage chaosmirage requested a review from a team January 15, 2026 15:38
@chaosmirage chaosmirage marked this pull request as ready for review January 15, 2026 15:40
@chaosmirage chaosmirage requested a review from a team as a code owner January 15, 2026 15:40
Copilot AI review requested due to automatic review settings January 15, 2026 15:40
@chaosmirage chaosmirage force-pushed the feat/migrate-devextreme-to-nx-part-2 branch from de4bf99 to 1de99ac Compare January 15, 2026 15:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the Nx migration for DevExtreme by removing the dev mode flag from build scripts, introducing new build workflow orchestration through a dedicated workflows package, and migrating the localization build process to a new Nx executor. The changes simplify the build system by eliminating conditional dev/prod logic in favor of distinct Nx targets and configurations.

Changes:

  • Removed dev mode flag from build-all.ts script, always running full production builds
  • Created new workflows package with all:build-dev and all:build-testing targets for build orchestration
  • Migrated localization generation from Gulp tasks to a new Nx executor with comprehensive E2E tests
  • Enhanced copy-files and add-license-headers executors with glob pattern and custom template support
  • Updated CI workflows to use Nx configurations instead of environment variables
  • Changed executor logging from logger.info to logger.verbose for cleaner output

Reviewed changes

Copilot reviewed 39 out of 40 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/scripts/build-all.ts Removed yargs dependency and dev mode conditional logic, always runs production build steps
package.json Changed all:build-dev to use new workflows target instead of passing --dev flag
packages/workflows/project.json New package defining all:build-dev and all:build-testing workflow targets
packages/nx-infra-plugin/src/executors/localization/* New localization executor replacing Gulp tasks with E2E tests
packages/nx-infra-plugin/src/executors/copy-files/* Enhanced with glob pattern support and additional tests
packages/nx-infra-plugin/src/executors/add-license-headers/* Enhanced with custom template support and refactored tests
packages/nx-infra-plugin/src/executors/*/executor.ts Changed logging from logger.info to logger.verbose for cleaner console output
packages/nx-infra-plugin/package.json Added lodash and @types/lodash dependencies, changed fs-extra to exact version
packages/devextreme/project.json Added granular build targets, removed npm script-based build, added testing configuration
packages/devextreme/package.json Removed build script (now handled by Nx target)
packages/devextreme/build/gulp/localization.js Replaced complex Gulp tasks with shell command calling Nx executor
packages/devextreme-angular/project.json Added testing configuration and updated dependsOn with params forwarding
.github/workflows/*.yml Updated to use all:build-testing workflow and testing configurations
pnpm-lock.yaml Various minor dependency version updates
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@chaosmirage chaosmirage force-pushed the feat/migrate-devextreme-to-nx-part-2 branch from 1de99ac to ff5e0d5 Compare January 16, 2026 08:55
Copilot AI review requested due to automatic review settings January 16, 2026 14:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 39 out of 40 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

"executor": "nx:run-commands",
"dependsOn": ["^build"],
"dependsOn": [
{
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an incorrect indentation on line 171. The opening brace should be aligned with the array bracket on line 170. This makes the JSON structure invalid and will cause parsing errors.

Suggested change
{
{

Copilot uses AI. Check for mistakes.
},
"dependencies": {
"fs-extra": "^11.2.0",
"fs-extra": "11.2.0",
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fs-extra version specifier was changed from a range ^11.2.0 to an exact version 11.2.0. While this provides more deterministic builds, it prevents automatic patch version updates that might include security fixes. Consider using the tilde ~ specifier instead (e.g., ~11.2.0) to allow patch updates while maintaining the same minor version.

Suggested change
"fs-extra": "11.2.0",
"fs-extra": "~11.2.0",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant