Skip to content

Conversation

@Tucchhaa
Copy link
Contributor

No description provided.

@Tucchhaa Tucchhaa self-assigned this Jan 14, 2026
@Tucchhaa Tucchhaa added the 26_1 label Jan 15, 2026
@Tucchhaa Tucchhaa marked this pull request as ready for review January 15, 2026 13:59
@Tucchhaa Tucchhaa requested a review from a team as a code owner January 15, 2026 13:59
Copilot AI review requested due to automatic review settings January 15, 2026 13:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue T1310524 regarding inconsistent application of the shadeUntilCurrentTime property to resources outside the viewport in virtual scrolling mode for the Scheduler component.

Changes:

  • Removed the getRoundedCellWidth method from the workspace class, which was calculating cell widths based on actual DOM measurements across groups
  • Refactored getIndicationWidth and getIndicatorOffset methods to no longer accept groupIndex parameter and instead use a consistent getCellWidth() value
  • Renamed _getIndicatorDuration to _getIndicatorDaysSpan for better clarity
  • Updated all method call sites to remove the groupIndex parameter
  • Added new TestCafe end-to-end tests specifically for virtual scrolling scenarios

Reviewed changes

Copilot reviewed 7 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/devextreme/js/__internal/scheduler/workspaces/m_work_space.ts Removed the getRoundedCellWidth method that was calculating cell widths based on DOM measurements
packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_indicator.ts Refactored width/offset calculations to use consistent cell width values instead of group-specific measurements; renamed _getIndicatorDuration to _getIndicatorDaysSpan
packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_grouped_strategy_horizontal.ts Updated calls to getShaderWidth and removed group index parameters from getCellWidth calls
packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_grouped_strategy_vertical.ts Updated call to getIndicationWidth to match new signature
packages/devextreme/js/__internal/scheduler/shaders/m_current_time_shader_vertical.ts Updated _getShaderWidth calls to not pass group index parameter
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/currentTimeIndicator.tests.js Updated QUnit tests to use getCellWidth() instead of getRoundedCellWidth(1) or getRoundedCellWidth(0)
e2e/testcafe-devextreme/tests/scheduler/common/layout/timeIndication/shaderVirtualScrolling.ts Added new TestCafe tests to verify shader rendering with virtual scrolling in different scroll positions

@Tucchhaa Tucchhaa merged commit 6242b29 into DevExpress:26_1 Jan 16, 2026
99 of 100 checks passed
@Tucchhaa Tucchhaa deleted the shade_until_current_time_26_1 branch January 16, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants