-
Notifications
You must be signed in to change notification settings - Fork 664
Scheduler: T1310524 — shadeUntilCurrentTime property is inconsistently applied to resources outside the viewport in virtual scrolling mode #32187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduler: T1310524 — shadeUntilCurrentTime property is inconsistently applied to resources outside the viewport in virtual scrolling mode #32187
Conversation
…cchhaa/DevExtreme into shade_until_current_time_26_1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses issue T1310524 regarding inconsistent application of the shadeUntilCurrentTime property to resources outside the viewport in virtual scrolling mode for the Scheduler component.
Changes:
- Removed the
getRoundedCellWidthmethod from the workspace class, which was calculating cell widths based on actual DOM measurements across groups - Refactored
getIndicationWidthandgetIndicatorOffsetmethods to no longer acceptgroupIndexparameter and instead use a consistentgetCellWidth()value - Renamed
_getIndicatorDurationto_getIndicatorDaysSpanfor better clarity - Updated all method call sites to remove the
groupIndexparameter - Added new TestCafe end-to-end tests specifically for virtual scrolling scenarios
Reviewed changes
Copilot reviewed 7 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/devextreme/js/__internal/scheduler/workspaces/m_work_space.ts |
Removed the getRoundedCellWidth method that was calculating cell widths based on DOM measurements |
packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_indicator.ts |
Refactored width/offset calculations to use consistent cell width values instead of group-specific measurements; renamed _getIndicatorDuration to _getIndicatorDaysSpan |
packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_grouped_strategy_horizontal.ts |
Updated calls to getShaderWidth and removed group index parameters from getCellWidth calls |
packages/devextreme/js/__internal/scheduler/workspaces/m_work_space_grouped_strategy_vertical.ts |
Updated call to getIndicationWidth to match new signature |
packages/devextreme/js/__internal/scheduler/shaders/m_current_time_shader_vertical.ts |
Updated _getShaderWidth calls to not pass group index parameter |
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/currentTimeIndicator.tests.js |
Updated QUnit tests to use getCellWidth() instead of getRoundedCellWidth(1) or getRoundedCellWidth(0) |
e2e/testcafe-devextreme/tests/scheduler/common/layout/timeIndication/shaderVirtualScrolling.ts |
Added new TestCafe tests to verify shader rendering with virtual scrolling in different scroll positions |
No description provided.