refactor: clarify GameText color terminology - #378
Merged
Merged
Conversation
* Rename the Team.GameText property to GameTextColor to clarify that it stores an open.mp GameText text color. * Update related message resources and usages to consistently use GameTextColor terminology, and document the supported text colors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
Team.GameTextproperty did not clearly communicate what the value represents. The property stores an open.mp GameText text color, such as~r~or~b~, rather than a GameText style.This ambiguity was also reflected in the message resources, where
GameTextandGameTextStylewere used inconsistently for the same color-related concept.The terminology should clearly distinguish the GameText text color from the GameText style used when displaying a GameText message.
Changes
Team.GameTexttoTeam.GameTextColor.GameTextmessage resource toGameTextColor.GameTextStylemessage resource toGameTextColor.GameTextColorterminology.