Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Application/Maps/Rotation/MapRotationService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ private void OnLoadingMap()
{
_isMapLoading = true;
LoadingMapEvent?.Invoke();
var matchResult = MatchResult.Create(Team.Alpha, Team.Beta);
worldService.SendClientMessage(Color.Yellow, matchResult.Announcement);
mapObjects.Unload();

IEnumerable<Player> players = MatchPlayers.GetAll();
Expand Down
20 changes: 5 additions & 15 deletions src/Application/Teams/Matches/MatchResult.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,29 +3,19 @@
public class MatchResult
{
public Team Winner { get; }
public string Announcement { get; }
public bool IsTie => Winner == Team.None;

private MatchResult(Team winner, string announcement)
{
Winner = winner;
Announcement = announcement;
}
private MatchResult(Team winner)
=> Winner = winner;

public static MatchResult Create(Team firstTeam, Team secondTeam)
{
if (firstTeam.IsWinner())
return new MatchResult(
firstTeam,
Smart.Format(Messages.TeamIsWinner, new { firstTeam.Name })
);
return new MatchResult(firstTeam);

if (secondTeam.IsWinner())
return new MatchResult(
secondTeam,
Smart.Format(Messages.TeamIsWinner, new { secondTeam.Name })
);
return new MatchResult(secondTeam);

return new MatchResult(Team.None, Messages.TiedTeams);
return new MatchResult(Team.None);
}
}
17 changes: 17 additions & 0 deletions src/Application/Teams/Matches/MatchResultAnnouncer.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
namespace CTF.Application.Teams.Matches;

public class MatchResultAnnouncer(IWorldService worldService)
{
public void Announce()
{
MatchResult result = MatchResult.Create(Team.Alpha, Team.Beta);

string resultMessage = result.IsTie ?
Messages.TiedTeams :
Smart.Format(
Messages.TeamIsWinner,
new { result.Winner.Name });

worldService.SendClientMessage(Color.Yellow, resultMessage);
}
}
1 change: 1 addition & 0 deletions src/Application/Teams/ServiceCollectionExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ public static IServiceCollection AddTeamServices(this IServiceCollection service
.AddSingleton<TeamIconService>()
.AddSingleton<TeamTextDrawRenderer>()
.AddSingleton<TeamBalancer>()
.AddSingleton<MatchResultAnnouncer>()
.AddSingleton<ClassSelectionTextDrawRenderer>()
.AddFlagServices();

Expand Down
2 changes: 2 additions & 0 deletions src/Host/Extensions/HostEcsBuilderExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,10 @@ public static IEcsBuilder RegisterMapEventHandlers(this IEcsBuilder builder)
var mapRotationService = builder.Services.GetRequiredService<MapRotationService>();
var rocketLauncherSystem = builder.Services.GetRequiredService<RocketLauncherSystem>();
var gunGameSystem = builder.Services.GetRequiredService<GunGameSystem>();
var matchResultAnnouncer = builder.Services.GetRequiredService<MatchResultAnnouncer>();
mapRotationService.LoadingMapEvent += rocketLauncherSystem.OnLoadingMap;
mapRotationService.LoadingMapEvent += gunGameSystem.OnLoadingMap;
mapRotationService.LoadingMapEvent += matchResultAnnouncer.Announce;
return builder;
}

Expand Down
1 change: 1 addition & 0 deletions src/Host/Usings.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
global using CTF.Application.Teams.Flags;
global using CTF.Application.Teams.Flags.Carriers;
global using CTF.Application.Teams.Flags.AutoReturn;
global using CTF.Application.Teams.Matches;
global using CTF.Application.Maps;
global using CTF.Application.Maps.Rotation;
global using CTF.Application.GunGames;
Expand Down
3 changes: 0 additions & 3 deletions tests/Application.Tests/Teams/MatchResultTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ public void Create_WhenAlphaTeamWins_ShouldReturnAlphaAsWinner()
// Assert
result.Winner.Should().Be(Team.Alpha);
result.IsTie.Should().BeFalse();
result.Announcement.Should().Be(Messages.AlphaIsWinner);
}

[Test]
Expand All @@ -36,7 +35,6 @@ public void Create_WhenBetaTeamWins_ShouldReturnBetaAsWinner()
// Assert
result.Winner.Should().Be(Team.Beta);
result.IsTie.Should().BeFalse();
result.Announcement.Should().Be(Messages.BetaIsWinner);
}

[Test]
Expand All @@ -52,6 +50,5 @@ public void Create_WhenNoTeamWins_ShouldReturnTieResult()
// Assert
result.Winner.Should().Be(Team.None);
result.IsTie.Should().BeTrue();
result.Announcement.Should().Be(Messages.TiedTeams);
}
}
Loading