refactor: improve weapon catalog domain naming - #375
Merged
Merged
Conversation
- Rename WeaponCatalogBase to WeaponCatalog. - Rename WeaponCatalog to ActiveWeaponCatalog. - Update XML documentation to better reflect the revised domain terminology.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The previous naming introduced ambiguity between two different weapon catalog domain concepts.
WeaponCatalogrepresented the active weapon catalog, while the core domain concept was namedWeaponCatalogBase, forcing the most important concept to carry an implementation-oriented suffix.Changes
WeaponCatalogBasetoWeaponCatalog.WeaponCatalogtoActiveWeaponCatalog.Benefits
ActiveWeaponCatalogclearly communicates that it represents the weapon catalog currently selected by the server configuration.Basesuffix from the domain model.