Skip to content

Issue #135 Navbar Positioning and Added Lunchtime in timetable - #149

Merged
Ayush04-C merged 4 commits into
masterfrom
sarvottam
Jun 3, 2026
Merged

Ayush04-C merged 4 commits into
masterfrom
sarvottam

Conversation

@sarvottamchaturvedi

Copy link
Copy Markdown
Collaborator
  1. Solved issue Navbar positioning #135 Navbar Positioning
  2. Added indicator for official lunchtime (12:30-2pm) in weekly and daily timetables

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Timetable UI to address the reported “fixed/overlaying navbar” behavior on scroll and to visually mark the official lunch window in both day and week timetable views.

Changes:

  • Removed the sticky positioning from the Timetable page heading wrapper to prevent it from overlaying content while scrolling.
  • Added “LUNCH” overlay blocks to Day and Week timetable grids to indicate the 12:30–14:00 lunch period.
  • Made the Week grid a positioned container (position: relative) so the week lunch overlay can be absolutely positioned correctly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/Timetable/TimetableContainer.jsx Outdated
Comment thread src/components/Timetable/TimetableContainer.jsx
Comment thread src/components/Timetable/TimetableContainer.jsx
For better formatting and readability of code

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Ayush04-C
Ayush04-C requested a review from Copilot June 3, 2026 05:31
@Ayush04-C
Ayush04-C merged commit 430f456 into master Jun 3, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.

<DayEventColumn>
{isToday && <CurrentTimeIndicator />}

<LunchBlock>LUNCH</LunchBlock>
))}
</WeekTimeColumn>

<WeekLunchBlock>LUNCH</WeekLunchBlock>
Comment on lines +2412 to +2414
/* position: sticky; */
/* top: 0; */
/* z-index: 100; */
Comment on lines +2412 to +2414
/* position: sticky; */
/* top: 0; */
/* z-index: 100; */
Comment on lines +3133 to +3137
position: absolute;
top: 240px;
left: 0;
width: 100%;
height: 90px;
Comment on lines +3161 to +3165
position: absolute;
top: 240px;
left: 80px;
width: calc(100% - 80px);
height: 90px;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants