fix(ci): scope CI deploy to hosting+rules (functions stay manual) - #51
Merged
Conversation
PR50 added defineSecret vars to functions .env, causing Cloud Run secret/non-secret env overlap (all functions failed). Reverted those additions and scoped CI deploy to hosting+firestore. Functions deploy manually with real Secret Manager values until those secrets are provisioned for the CI service account.
|
🔥 Firebase Hosting preview: https://open-ten99--pr-51-6s9h80ws.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR50 wrote defineSecret-backed vars into the functions .env, which Cloud Run rejects (secret env var overlaps non-secret env var) - every function failed to update. Reverted those .env additions and changed the deploy to --only hosting,firestore. Hosting + rules deploy reliably via CI; functions are deployed manually with real Secret Manager values (current practice, site + email are live). Re-enabling functions in CI requires provisioning the Notion/Stripe/Plaid/Token/Brevo secrets in Secret Manager for the WIF service account - an infra task, separate from app code.