fix(ci): unblock Firebase deploy workflow (missing functions env params) - #50
Merged
Conversation
Deploy workflow only wrote 6 of the functions params; non-interactive deploy failed needing NOTION/STRIPE/PLAID/TOKEN_ENCRYPTION_KEY/BREVO_API_KEY. Added them with the same secret-or-placeholder pattern. defineSecret values still resolve from Secret Manager at runtime.
|
🔥 Firebase Hosting preview: https://open-ten99--pr-50-dy4mu83h.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Deploy to Firebase workflow died non-interactively: it only wrote 6 functions params to .env, but the codebase also needs NOTION_CLIENT_ID/SECRET, NOTION_REDIRECT_URI, STRIPE_WEBHOOK_SECRET, PLAID_CLIENT_ID/SECRET/ENV, TOKEN_ENCRYPTION_KEY, BREVO_API_KEY. Pre-existing gap (those integrations were never wired into CI); Brevo just added one more. Extended the existing secret-or-placeholder pattern. defineSecret values still come from Secret Manager at runtime, so live integrations are unaffected. Hosting was always fine (deployed manually). Merging re-triggers the workflow as the test.