Add keyboard support for nouislider#15
Open
iamDecode wants to merge 4 commits intoDesignRevision:masterfrom
Open
Add keyboard support for nouislider#15iamDecode wants to merge 4 commits intoDesignRevision:masterfrom
iamDecode wants to merge 4 commits intoDesignRevision:masterfrom
Conversation
requestedusernotfound
added a commit
to requestedusernotfound/shards-vue
that referenced
this pull request
Jan 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just ran into the issue that
<d-slider>did not have keyboard support. Luckily nouislider recently implemented this, so with minor changesshards-vuecan also support keyboard controls.NOTE: I regenerated the dist folder, it seems that the previous build was ran without
NODE_ENV = production.