Skip to content

[Draft] QoL patch v1#26

Draft
anzz1 wants to merge 29 commits into
Deokishisu:masterfrom
anzz1:qol-patch-v1
Draft

[Draft] QoL patch v1#26
anzz1 wants to merge 29 commits into
Deokishisu:masterfrom
anzz1:qol-patch-v1

Conversation

@anzz1
Copy link
Copy Markdown

@anzz1 anzz1 commented Feb 21, 2023

QoL Patch v1

This PR is a collection of various QoL additions and fixes.
I think I understand your design philosophy in this mod and tried to include only patches which fit the current design.

Everything is configurable by either key settings or compiler flags (with the exception of Espeon&Umbreon PC info entries).
Save and link compatibility is preserved.

It's a collective effort, so special thanks to everyone involved in the patches.

KEY SETTINGS

  • Allow Mons to evolve with rare candy and continue to gain EVs on lvl 100 (credits: 00mn00, AsparagusEduardo)
  • Allow replacing HM moves
  • Overworld poison damage: STANDARD / 1HP / DISABLED (credits: bugdorderoms, daniilS)
  • Disable flashbacks when loading a saved game (credits: bugdorderoms, Sierra)
  • Show ability popups at the beginning of battle in single-player (credits: 00mn00, bugdorderoms, DizzyEgg, CFRU, BlackUser)
  • Disable player/enemy/both using heal items in battle (credits: 00mn00)
  • Level Cap setting (credits: 00mn00)

BATTLE SCENE OPTIONS

  • Disable pokeball throw animation

COMPILER FLAGS

  • PICHU learns VOLT TACKLE if either parent is holding a LIGHT BALL (credits: bugdorderoms)
  • 1/16 chance of SHUCKLE making BERRY JUICE at end of battle if holding an ORAN BERRY (credits: 00mn00, bugdorderoms, AsparagusEduardo)
  • Show move types and categories as icons in battle (credits: 00mn00, Snaid1)
  • Expose type of WEATHER BALL and NATURE POWER in battle (credits: 00mn00, itskobold)
  • Celadon Game Corner Easter Egg
  • Better player reflection in overworld (credits: 00mn00, ghoulslash)
  • Better animation for opponent throwing a pokeball (credits: 00mn00, GhoulMage)
  • Skip intro copyright screen by pressing A/B/START (credits: 00mn00, devolov)
  • Show item description on first obtain (credits: 00mn00, bugdorderoms, BlackUser)
  • Allow choosing a Mon which is already out in battle (credits: 00mn00, devolov)
  • Move held items between Mons in party (credits: 00mn00, AsparagusEduardo, Deokishisu)
  • Show which Mons in party can learn selected TM (credits: 00mn00, Greenphx9)
  • ALTERING CAVE alters

NEW FEATURES

The code has been tidied up and bugs should be pretty much scrubbed, but further testing is still needed.
PR is marked as draft until testing is done.

Tested:

  • Max Lvl Evolve & EV Gain
  • Forget HM Moves
  • Overworld Poison Damage
  • Disable Flashbacks
  • Show Abilities
  • Disable pokeball animation
  • Take Held Item
  • Volt Tackle by breeding
  • Shuckle makes Berry Juice
  • Move type & category icons
  • Expose Weather Ball & Nature Power
  • Game Corner Easter Egg
  • Better player reflection
  • Opponent pokeball animation [x] Single [x] Dual
  • Skip Intro button
  • Show Item description on 1st obtain
  • Allow choosing current Mon
  • Move Held Items
  • TM Case Mon Sprites
  • Espeon&Umbreon visible in Bill's PC
  • Altering Cave alters
  • No Item Heals
  • Level Cap
  • Admin Sprites

TODO:

Suggestions and feedback welcome !

get patch | web

New options:

- Max Lvl Evolve & EV Gain (credits: 00mn00, AparagusEduardo)
- Forget HM Moves
- Overworld Poison Damage (credits: bugdorderoms, daniilS)
- Disable Flashbacks (credits: bugdorderoms, Sierra)
- Show Abilities (credits: 00mn00, bugdorderoms, DizzyEgg, CFRU, BlackUser)
- Disable Ball Anim
- Take Held Item (credits: citrusbolt)
- Volt Tackle by breeding (credits: bugdorderoms)
- Shuckle makes Berry Juice (credits: 00mn00, bugdorderoms, AsparagusEduardo)
- Move type & category icons (credits: 00mn00, Snaid1)
- Expose Weather Ball & Nature Power (credits: 00mn00, itskobold)
- Game Corner Easter Egg
- Better player reflection (credits: 00mn00, ghoulslash)
- Opponent pokeball animation (credits: 00mn00, GhoulMage)
- Skip Intro button (credits: 00mn00, devolov)
- Show Item description on 1st obtain (credits: 00mn00, bugdorderoms, BlackUser)
- Allow choosing current mon (credits: 00mn00, devolov)
- Move Held Items between Mons (credits: 00mn00, AsparagusEduardo, Deokishisu)
- TM Case Mon Sprites (credits: 00mn00, Greenphx9)
- Espeon & Umbreon visible in Bill's PC (credits: 00mn00, aerial-light)
@anzz1 anzz1 mentioned this pull request Feb 21, 2023
@anzz1 anzz1 mentioned this pull request Feb 22, 2023
@anzz1
Copy link
Copy Markdown
Author

anzz1 commented Feb 23, 2023

I also "made" this web patcher to make patching easier for people who cannot compile themselves. I think it promotes inclusivity to improve accessibility. Any thoughts?

if replaced move is at max PP, new move will also have max PP
@Zelly9191
Copy link
Copy Markdown

Zelly9191 commented Feb 24, 2023

Hey sorry to bother you i wasn't sure how to reach out to you.

Would it be possible to give the rival battle and team rocket their own themes?

If you don't think it really fits in the scope of the additions you want to add could you show me how to do it?
If yes do you have a discord account i can message you on.

I also had a small suggestion or two to throw your way let me know if you have any other way I can reach out to communicate with you more easily.

If I can help out at all I'd be more than glad to provide any assistance I can as well.

Also fantastic job on the web patcher.

@Zelly9191
Copy link
Copy Markdown

Additionally, I've discovered several TMs are permanently missable on the SS Anne since TMs last forever. Unless there is another way to get them, in which case you would be able to get multiple of one TM which would be just as bad. (I assume)

@anzz1
Copy link
Copy Markdown
Author

anzz1 commented Feb 25, 2023

Altering the graphics is indeed outside the scope of this project but the beauty of open-source is that you can tinker and create your own modifications as your heart desires.

The pokeemerald wiki is a great resource to get started on modifications. All the Gen3 games (Emerald/Ruby/Sapphire/FireRed/LeafGreen) share much of the codebase and use the same engine so much of the information there regarding Emerald can be applied almost directly to FRLG.


Additionally, I've discovered several TMs are permanently missable on the SS Anne since TMs last forever.

This is not a part of the mod, it's the original design and they are one of the few permanently missable items in the series. The game usually does not lock you out from backtracking and lets you retrieve anything you missed later on, but S.S. Anne is one of the exceptions to the rule.

Why they designed it this way, can only be speculated. There is a NPC dialogue where is said that the ship would be returning once a year, so maybe it was supposed to return but that the functionality ended up not making it into the final release. Or maybe not, who knows.

In any case, the author of this mod probably thought that the original design will be left as-is, and frankly, I agree. That being said, a returning S.S. Anne could be a great fun addition which wouldn't be detrimental to the overall design. So maybe it'd be a good idea?

edit: On further consideration since the TM44 (Rest) was the only missable non-consumable item in the whole game as the other S.S. Anne item TM31 (Brick Break) is not, I added the TM44 to the Celadon Dept. Store next to the TM31 which already was there.

@00mn00
Copy link
Copy Markdown

00mn00 commented Feb 28, 2023

Would it be possible to give the rival battle and team rocket their own themes?

I did this on my fork, in the "rsification" branch. Feel free to have a look and take what you want to use, no credit necessary.

@Zelly9191
Copy link
Copy Markdown

Thanks 00mn00 I'll check it out.

Anzz1 perhaps adding them to the game corner might be the easiest method as it prevents getting them if you already have the tm. Alternatively, you could add them to the department store as it does the same I think. I know the game corner does though. This would allow people to still get the TM without changing the game design to much.

It would also mean that skipping it would come at a cost to the player.

(Sent you another discord dm btw)

@anzz1 anzz1 marked this pull request as draft March 3, 2023 10:15
anzz1 added 2 commits March 3, 2023 16:13
it makes more sense
fix help legend for "reset settings" and change flashbacks -> noFlashbacks
anzz1 added 5 commits March 3, 2023 23:10
for now you can level mon over the keysetting defined levelcap in daycare
unique sprites for five island rocket warehouse admins (credits: CrystalDust Team)
- fix help not working after keysettings reset
- fix stats not recalculated after 2 consecutive keysettings resets
- ask to take held item is now always enabled
- also remove the now unused advanced settings 3 menu
@00mn00
Copy link
Copy Markdown

00mn00 commented Mar 15, 2023

I've been working on a couple of fixes for bugs that are in the base game, if I post the code will you look over it?

@anzz1
Copy link
Copy Markdown
Author

anzz1 commented Mar 15, 2023

I've been working on a couple of fixes for bugs that are in the base game, if I post the code will you look over it?

Sure ! 👍

@00mn00
Copy link
Copy Markdown

00mn00 commented Mar 15, 2023

I've been working on a couple of fixes for bugs that are in the base game, if I post the code will you look over it?

Sure ! 👍

00mn00@574d54c

@anzz1
Copy link
Copy Markdown
Author

anzz1 commented Mar 15, 2023

00mn00@574d54c

Cool, thanks ! I'll merge the changes to this qol fix ! 👍

@anzz1
Copy link
Copy Markdown
Author

anzz1 commented Mar 15, 2023

Snow Fix

Before After
before after

@00mn00
Copy link
Copy Markdown

00mn00 commented Mar 17, 2023

QoL branch you might consider rolling into this - https://github.com/00mn00/FRLG-Plus_Custom/tree/left_right_target_persists_in_double_battles

@Zelly9191
Copy link
Copy Markdown

I finished a version of the in battle type icons for now and sent them to you. :) They will possibly need improving later on but for now they will work fine. I think there are two I'd like to improve. But as I said they will work fine for now.

@Zelly9191
Copy link
Copy Markdown

I also got ahold of Jag and they will be sending the midi hopefully soon. I learned a bunch about how it will need to be implemented and I learned a way to fully upgrade the sound mixer.

@Deokishisu
Copy link
Copy Markdown
Owner

Hi.

While I would definitely be interested in pulling in some of these features and bug fixes, some of them are out of scope for this hack in my opinion.

Since it seems that this PR is going to get continued updates, perhaps it would be better for you to fork FRLG+ and continue development on your fork, since I will be cherry-picking from this PR when I get back to this project instead of merging the entire thing. If you'd like to leave a link to your fork here, that'd be cool.

Regardless, thanks for the interest and for all the work you've done for this!

@anzz1
Copy link
Copy Markdown
Author

anzz1 commented Mar 18, 2023

@Deokishisu
Yeah it kinda spiralled out a bit in terms of features. 😄
I'll freeze the features for this branch and be soon adding the bugfixes from @00mn00 and doing the last bits of fixing/cleaning/testing so the "v1" of this qol fix can be wrapped up and done.

@Zelly9191
Copy link
Copy Markdown

Hey @anzz1 could you dm me when you can.

@00mn00
Copy link
Copy Markdown

00mn00 commented Mar 28, 2023

Mosaic "fix" - 00mn00@92c30de - Deo will probably have a better fix at some point in the future, but this works perfectly well from my testing.

@00mn00
Copy link
Copy Markdown

00mn00 commented Mar 29, 2023

Daycare man "fix" - 00mn00@55af8c6 - Deo will probably have a better fix at some point in the future, but this works perfectly well from my testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants