chore(bug): fix vertical offset line chart issue#32
Open
Conversation
If a vertical offset was defined, this would cause overlays and rules to be offset upward by the number of pixels included in the offset. Fixed by applying the inverse offset to all y axis values.
guscost
reviewed
Jun 14, 2018
Contributor
guscost
left a comment
guscost
left a comment
There was a problem hiding this comment.
I don't understand what "vertical offset" means in this context, will have to look into it.
Contributor
Author
|
@guscost Look for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a vertical offset was defined, this would cause overlays and rules to
be offset upward by the number of pixels included in the offset. Fixed
by applying the inverse offset to all y axis values.
Before:
After:
