Skip to content

docs: add quality assurance checklist to PR template#137

Open
Chirantan112 wants to merge 2 commits into
Demon-Die:mainfrom
Chirantan112:add-pr-checklist
Open

docs: add quality assurance checklist to PR template#137
Chirantan112 wants to merge 2 commits into
Demon-Die:mainfrom
Chirantan112:add-pr-checklist

Conversation

@Chirantan112

@Chirantan112 Chirantan112 commented Jun 10, 2026

Copy link
Copy Markdown

🔗 Related Issue

Closes #123


📝 Description of Changes

Added a comprehensive Quality Assurance (QA) checklist to the existing pull request template. This checklist helps contributors verify their work across documentation, data updates, and UI/code changes before submitting, helping to reduce review back-and-forth.


🏷️ Proposed Labels

  • UI/UX
  • Documentation
  • CI/CD
  • Backend Logic
  • Anything else

📂 Core Files Changed

  • .github/PULL_REQUEST_TEMPLATE.md

🤖 AI Assistance Declaration

Did you use an AI tool to write or assist with this code OR Pull Request?

  • Yes
  • No (If no, you can skip the rest of this section)

⚠️ IF YOU CHECKED "YES", YOU MUST ANSWER THE FOLLOWING:

  • Which AI Model did you use? (e.g., GPT-4o, Claude 4.5 Sonnet):
  • Which Platform/Tool? (e.g., Cursor, OpenCode, Codex, Claude Code, GitHub Copilot, standard web chat):
  • What exactly did the AI do?:
  • What exactly did YOU do?:
  • What is the advantage of using this AI approach here?:

⚠️ Reviewer Notes

The checklist has been injected right in the middle of the existing template format, keeping your original header sections and the final verification pledge perfectly intact.


✅ The "I Swear I Didn't Break Anything" Pledge

  • I have thoroughly tested these changes in my own local branch.
  • I verified multiple times that this code compiles into a standalone build and does not break existing production features.

Summary by CodeRabbit

  • Documentation

    • Updated contributor roster and refreshed profile images in project documentation.
  • Chores

    • Enhanced pull request template with a Quality Assurance Checklist section to standardize the review process.

@vercel

vercel Bot commented Jun 10, 2026

Copy link
Copy Markdown

@Chirantan112 is attempting to deploy a commit to the Rishi Bhardwaj's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds contributor guidance and updates project credits. A quality assurance checklist was appended to the pull request template covering self-review, documentation, and UI verification. The README contributors section was refreshed with updated avatar links and includes a new contributor entry.

Changes

Documentation and Contributor Updates

Layer / File(s) Summary
PR template quality assurance checklist
.github/PULL_REQUEST_TEMPLATE.md
Added "Quality Assurance Checklist" section with checkbox items for self-review safeguards, documentation accuracy, and UI/code changes including build, lint, format, and responsive design verification.
Contributor list and avatar updates
README.md
Updated GitHub avatar image URLs for existing contributors and added new contributor entry for ded-furby in the contributors HTML table.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A checklist hops into the PR,
With checkmarks for quality near and far,
Contributors shine in the README's glow,
New faces and avatars steal the show!
✨📋✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes an out-of-scope change: updating contributor avatars and adding a new contributor to README.md, which is unrelated to issue #123's objective of adding a QA checklist to the PR template. Remove the README.md changes (avatar updates and new contributor addition) as they are outside the scope of adding a QA checklist to the PR template.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'docs: add quality assurance checklist to PR template' clearly and accurately reflects the main change—adding a QA checklist to the pull request template.
Linked Issues check ✅ Passed The PR meets the acceptance criteria from issue #123: includes 5+ practical QA items covering build, formatting, UI changes, and data validity; wording is contributor-focused; no application code changes were made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Around line 93-155: The avatar img src URLs in the README for contributors
like "rue-eru", "Yuvraj-Sarathe", "Dhrubajyoti930", "Amresh Anand", "RishiByte",
"nishtha-agarwal-211", "Kenny Hietbrink", "maitriupadhyay03-cell", "Arnav
Bhilwariya", "ANUSHKA R SHETTY", and "sakshimuttha578" contain duplicate s=100
query parameters; update each <img src="..."> URL so the query string only
includes a single instance of each parameter (e.g., ?v=4&s=100) to match the
correct format used for the newly added contributor and remove all repeated
s=100 entries.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 284b424c-cc2a-49d0-ac7f-cb290ab164fb

📥 Commits

Reviewing files that changed from the base of the PR and between cb4c939 and 653cf2b.

📒 Files selected for processing (2)
  • .github/PULL_REQUEST_TEMPLATE.md
  • README.md

Comment thread README.md
Comment on lines +93 to +155
<img src="https://avatars.githubusercontent.com/u/162464326?v=4&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100" width="80px;" alt="rue-eru"/><br />
<sub><b>rue-eru</b></sub>
</a>
</td>
<td align="center">
<a href="https://github.com/Yuvraj-Sarathe" title="Yuvraj-Sarathe">
<img src="https://avatars.githubusercontent.com/u/216678101?v=4&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100" width="80px;" alt="Yuvraj-Sarathe"/><br />
<img src="https://avatars.githubusercontent.com/u/216678101?v=4&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100" width="80px;" alt="Yuvraj-Sarathe"/><br />
<sub><b>Yuvraj-Sarathe</b></sub>
</a>
</td>
<td align="center">
<a href="https://github.com/Dhrubajyoti930" title="Dhrubajyoti930">
<img src="https://avatars.githubusercontent.com/u/149499573?v=4&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100" width="80px;" alt="Dhrubajyoti930"/><br />
<img src="https://avatars.githubusercontent.com/u/149499573?v=4&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100" width="80px;" alt="Dhrubajyoti930"/><br />
<sub><b>Dhrubajyoti930</b></sub>
</a>
</td>
<td align="center">
<a href="https://github.com/amreshanand" title="Amresh Anand">
<img src="https://avatars.githubusercontent.com/u/225670667?v=4&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100" width="80px;" alt="Amresh Anand"/><br />
<img src="https://avatars.githubusercontent.com/u/225670667?v=4&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100" width="80px;" alt="Amresh Anand"/><br />
<sub><b>Amresh Anand</b></sub>
</a>
</td>
<td align="center">
<a href="https://github.com/RishiByte" title="RishiByte">
<img src="https://avatars.githubusercontent.com/u/227175134?v=4&s=100&s=100&s=100&s=100&s=100&s=100&s=100" width="80px;" alt="RishiByte"/><br />
<img src="https://avatars.githubusercontent.com/u/227175134?v=4&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100" width="80px;" alt="RishiByte"/><br />
<sub><b>RishiByte</b></sub>
</a>
</td>
<td align="center">
<a href="https://github.com/nishtha-agarwal-211" title="nishtha-agarwal-211">
<img src="https://avatars.githubusercontent.com/u/242000265?v=4&s=100&s=100&s=100&s=100&s=100&s=100" width="80px;" alt="nishtha-agarwal-211"/><br />
<img src="https://avatars.githubusercontent.com/u/242000265?v=4&s=100&s=100&s=100&s=100&s=100&s=100&s=100" width="80px;" alt="nishtha-agarwal-211"/><br />
<sub><b>nishtha-agarwal-211</b></sub>
</a>
</td>
</tr>
<tr>
<td align="center">
<a href="https://github.com/dev" title="Kenny Hietbrink">
<img src="https://avatars.githubusercontent.com/u/12158001?v=4&s=100&s=100&s=100&s=100&s=100" width="80px;" alt="Kenny Hietbrink"/><br />
<img src="https://avatars.githubusercontent.com/u/12158001?v=4&s=100&s=100&s=100&s=100&s=100&s=100" width="80px;" alt="Kenny Hietbrink"/><br />
<sub><b>Kenny Hietbrink</b></sub>
</a>
</td>
<td align="center">
<a href="https://github.com/maitriupadhyay03" title="maitriupadhyay03-cell">
<img src="https://github.com/maitriupadhyay03.png?s=100&s=100&s=100&s=100" width="80px;" alt="maitriupadhyay03-cell"/><br />
<img src="https://github.com/maitriupadhyay03.png?s=100&s=100&s=100&s=100&s=100" width="80px;" alt="maitriupadhyay03-cell"/><br />
<sub><b>maitriupadhyay03-cell</b></sub>
</a>
</td>
<td align="center">
<a href="https://github.com/arnavbhilwariya0408" title="Arnav Bhilwariya">
<img src="https://github.com/arnavbhilwariya0408.png?s=100&s=100&s=100" width="80px;" alt="Arnav Bhilwariya"/><br />
<img src="https://github.com/arnavbhilwariya0408.png?s=100&s=100&s=100&s=100" width="80px;" alt="Arnav Bhilwariya"/><br />
<sub><b>Arnav Bhilwariya</b></sub>
</a>
</td>
<td align="center">
<a href="https://github.com/Anushkarshetty45" title="ANUSHKA R SHETTY">
<img src="https://avatars.githubusercontent.com/u/188852743?v=4&s=100&s=100" width="80px;" alt="ANUSHKA R SHETTY"/><br />
<img src="https://avatars.githubusercontent.com/u/188852743?v=4&s=100&s=100&s=100" width="80px;" alt="ANUSHKA R SHETTY"/><br />
<sub><b>ANUSHKA R SHETTY</b></sub>
</a>
</td>
<td align="center">
<a href="https://github.com/mutthasakshi578" title="sakshimuttha578">
<img src="https://github.com/mutthasakshi578.png?s=100" width="80px;" alt="sakshimuttha578"/><br />
<img src="https://github.com/mutthasakshi578.png?s=100&s=100" width="80px;" alt="sakshimuttha578"/><br />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Fix malformed avatar URLs with duplicate query parameters.

Lines 93-155 contain avatar URLs with duplicate s=100 query parameters (repeated 2-10 times per URL). While browsers may be lenient, this is technically incorrect URL syntax and could cause caching or image loading issues. Only the newly added contributor on line 161 has the correct format.

For example, line 93 has:

?v=4&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100

Should be:

?v=4&s=100
🔧 Proposed fix to remove duplicate parameters
-        <img src="https://avatars.githubusercontent.com/u/162464326?v=4&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100&s=100" width="80px;" alt="rue-eru"/><br />
+        <img src="https://avatars.githubusercontent.com/u/162464326?v=4&s=100" width="80px;" alt="rue-eru"/><br />

Apply the same fix pattern to all affected lines (93, 99, 105, 111, 117, 123, 131, 137, 143, 149, 155): keep only the first occurrence of each query parameter.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` around lines 93 - 155, The avatar img src URLs in the README for
contributors like "rue-eru", "Yuvraj-Sarathe", "Dhrubajyoti930", "Amresh Anand",
"RishiByte", "nishtha-agarwal-211", "Kenny Hietbrink", "maitriupadhyay03-cell",
"Arnav Bhilwariya", "ANUSHKA R SHETTY", and "sakshimuttha578" contain duplicate
s=100 query parameters; update each <img src="..."> URL so the query string only
includes a single instance of each parameter (e.g., ?v=4&s=100) to match the
correct format used for the newly added contributor and remove all repeated
s=100 entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a pull request checklist for contributors

1 participant