Skip to content

feat(helm): add environment variables to support open source models for ab testing #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dembrane-sam-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(helm): add environment variables to support open source models for ab testing #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions helm/echo/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,22 @@ Common environment variables (including feature flags and non-sensitive config)
- name: ASSEMBLYAI_WEBHOOK_URL
value: {{ . | quote }}
{{- end }}
{{- with (default "" .Values.common.env.LLM__OPEN_SOURCE__MODEL) }}
- name: LLM__OPEN_SOURCE__MODEL
value: {{ . | quote }}
{{- end }}
{{- with (default "" .Values.common.env.LLM__OPEN_SOURCE__VERTEX_LOCATION) }}
- name: LLM__OPEN_SOURCE__VERTEX_LOCATION
value: {{ . | quote }}
{{- end }}
{{- with (default "" .Values.common.env.LLM__OPEN_SOURCE__VERTEX_PROJECT) }}
- name: LLM__OPEN_SOURCE__VERTEX_PROJECT
value: {{ . | quote }}
{{- end }}
{{- with (default "" .Values.common.env.LLM__OPEN_SOURCE__API_BASE) }}
- name: LLM__OPEN_SOURCE__API_BASE
value: {{ . | quote }}
{{- end }}
{{- end }}

{{/*
Expand Down Expand Up @@ -201,4 +217,15 @@ All secret-based environment variables
name: echo-backend-secrets
key: ASSEMBLYAI_WEBHOOK_SECRET
optional: true
- name: LLM__OPEN_SOURCE__GCP_SA_JSON
valueFrom:
secretKeyRef:
name: echo-backend-secrets
key: GCP_SA_JSON
- name: LLM__OPEN_SOURCE__API_KEY
valueFrom:
secretKeyRef:
name: echo-backend-secrets
key: LLM__OPEN_SOURCE__API_KEY
optional: true
{{- end }}
6 changes: 6 additions & 0 deletions helm/echo/values-extended-env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,9 @@ common:

EMBEDDING_MODEL: "vertex_ai/text-embedding-004"
EMBEDDING_BASE_URL: "https://europe-west4-aiplatform.googleapis.com"

# Open Source model configurations for preference A/B testing
LLM__OPEN_SOURCE__MODEL: "vertex_ai/mistral-large"
LLM__OPEN_SOURCE__VERTEX_LOCATION: "europe-west4"
LLM__OPEN_SOURCE__VERTEX_PROJECT: ""
LLM__OPEN_SOURCE__API_BASE: ""