Issue #1772 Bug fix writing clipped idf_svat.#1781
Open
Conversation
|
JoerivanEngelen
requested changes
Mar 12, 2026
Contributor
JoerivanEngelen
left a comment
JoerivanEngelen
left a comment
There was a problem hiding this comment.
Thanks for adding the test and proposing a fix! I'm not happy yet with the location of the fix though. If you can move the logic to IdfMapping._render (I gave some suggestions), we utilize the strengths of the current architecture a lot better.
| Collect to be written data in a DataFrame and call | ||
| ``self.write_dataframe_fixed_width`` | ||
| """ | ||
| if self.__class__.__name__ == "IdfMapping": |
Contributor
There was a problem hiding this comment.
This works, but we don't want special logic for IdfMapping in the Package baseclass (unless there is no other way).
In this case, you can override the _render method in the IdfMapping class, in the imod/msw/idf_mapping.py file. In pseudo-code:
class IdfMapping:
...
def _render(
self,
...
) -> None:
<all logic to compute rows, cols, x_grid, and y_grid>
self.dataset["rows"] = rows
self.dataset["columns"] = columns
self.dataset["x_grid"] = x_grid
self.dataset["y_grid"] = y_grid
super()._render(...) | assert_almost_equal(results["x_grid"], np.array([2.0, 2.0, 2.0, 2.0, 4.0])) | ||
|
|
||
|
|
||
| def test_idf_oc_write_simple_model_clip(fixed_format_parser): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1772
Description
Bug fix for row/column indices when writing a clipped version of idf_svat.inp.
Checklist
Issue #nr, e.g.Issue #737pixi run generate-sbomand committed changes