Skip to content

Building drainage#308

Draft
hcastrol wants to merge 3 commits into
Deltares:mainfrom
hcastrol:buildingdrainage
Draft

Building drainage#308
hcastrol wants to merge 3 commits into
Deltares:mainfrom
hcastrol:buildingdrainage

Conversation

@hcastrol

@hcastrol hcastrol commented Apr 2, 2026

Copy link
Copy Markdown

Building implementation (IMDC):

  • Building coordinates are defined in: bldfile = sfincs.bld
  • Building properties are defined in: bprfile = sfincs.bpr

Steps:

  • Rain is retained on building roofs (up to volume indicated in bprfile)
  • Excess water is released through user-defined gutter system

@Leynse

Leynse commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator

Hi Hilario,

@maartenvanormondt made a cleaned up version of your code in PR #317 , could you run and test this version whether the outcome is still the same for your test model?

Afterwards I'll have a more detailed look into the implementation myself, thanks!

Tim

@Leynse Leynse marked this pull request as draft April 16, 2026 08:05
@Leynse Leynse modified the milestone: 2026.02 release May 6, 2026
@hcastrol

hcastrol commented Jun 4, 2026

Copy link
Copy Markdown
Author

Hi Tim,

We’ve done some checks on your implementation at both small and large spatial scales. For the small-scale test model, we only found minor differences at the discharge cells of the gutter system. At the larger scale, with a uniform water distribution around the buildings, these differences are negligible. So it looks good on our side.

My colleague Rob Schepper will be looking into the implementation of the run-off with the initialization implemented in the sfincs_initalization script. We will resubmit the pull request in the next days.

Best,
Hilario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants