Building drainage#308
Conversation
|
Hi Hilario, @maartenvanormondt made a cleaned up version of your code in PR #317 , could you run and test this version whether the outcome is still the same for your test model? Afterwards I'll have a more detailed look into the implementation myself, thanks! Tim |
|
Hi Tim, We’ve done some checks on your implementation at both small and large spatial scales. For the small-scale test model, we only found minor differences at the discharge cells of the gutter system. At the larger scale, with a uniform water distribution around the buildings, these differences are negligible. So it looks good on our side. My colleague Rob Schepper will be looking into the implementation of the run-off with the initialization implemented in the sfincs_initalization script. We will resubmit the pull request in the next days. Best, |
Building implementation (IMDC):
Steps: