Skip to content

Support multiple DAMO versions#238

Draft
guydup wants to merge 13 commits into
mainfrom
damo
Draft

Support multiple DAMO versions#238
guydup wants to merge 13 commits into
mainfrom
damo

Conversation

@guydup

@guydup guydup commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator
  1. support multiple DAMO versions by converting each supported DAMO version (2.2, 2.3, 2.4 and 2.5) to our existing internal data structure
  2. adds a new dependency to the existing HyDAMOValidatieModule for optional validation
  3. PR uses a version number (1.5.0) that does not support DAMO 2.5 yet DAMO 2.5 validation is proposed in Feature/HyDAMO_2_5 HetWaterschapshuis/HyDAMOValidatieModule#33

@guydup

guydup commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

HyDAMOValidatieModule pins python to 3.12. We probably don't want that. Since validation is completely optional, I removed it from the pyproject.toml and leave it up to the user to install the validation module if desired.

@guydup

guydup commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

moved HyDAMOValidatieModule to being completely optional and only run the test on 3.12

Ergonomics of loading damo layers is much better now I think

@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant