Skip to content
This repository was archived by the owner on Oct 26, 2025. It is now read-only.
This repository was archived by the owner on Oct 26, 2025. It is now read-only.

Merge "develop" to "master" and release new NuGet package version #14

Open

Description

@davidnguyen

Hi,
I'm trying to get Atlas to work with Sitecore 9 and it's all well and good except the LinkFieldRenderingString class still has some dependency to CommonServiceLocator. In Sitecore 9, CommonServiceLocator is still used, but reserved for Solr integration only. This breaks on any ViewModel class that uses ILinkFieldRenderingString. The fix for this has already merge to the "develop" branch. It would be great if it could be merged to master, and release a new version of NuGet package.

Thanks,
David Nguyen

Activity

  1. heikof commented on Dec 6, 2017

    @heikof
    Collaborator

    Hi @davidnguyen - which change on the develop branch are you referring to? Or do you mean pull request #13 ?

  2. geekrocket commented on Dec 7, 2017

    @geekrocket
    Collaborator

    Previous fixes (not including DI) have been merged and tagged as v1.0.1, with the final DI changes being pulled through from PR #13 to PR #16 (pending review) which will go out as v1.1.0 - with Sitecore 8.2 being the minimum version required.

  3. davidnguyen commented on Dec 22, 2017

    @davidnguyen
    ContributorAuthor

    @heikof @geekrocket thanks guys, can you let me know when the new NuGet package v1.0.1, or v1.1.0 can be released?

  4. davidnguyen commented on Feb 1, 2018

    @davidnguyen
    ContributorAuthor

    @geekrocket can we do a NuGet package release on the latest code mate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions