fix: make async runtime and context Send/Sync without parallel feature#680
Closed
richarddd wants to merge 1 commit intoDelSkayn:masterfrom
Closed
fix: make async runtime and context Send/Sync without parallel feature#680richarddd wants to merge 1 commit intoDelSkayn:masterfrom
richarddd wants to merge 1 commit intoDelSkayn:masterfrom
Conversation
Collaborator
|
I am very unconvinced about that one. Parallel also enables a bunch of things like Mutex for Ref, JS_UpdateStackTop calls, etc. that are required for it to work correctly multi-threaded. |
Collaborator
Author
|
Yeah true, let's ditch it and close the issue. Better to be safe here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #495
Description of changes
AsyncRuntime,AsyncContext, andWithFutureare now unconditionallySend/Syncsoasync_withcan be used with multi-threaded executors without requiring theparallelfeature, since the underlyingArc<async_lock::Mutex<_>>is already thread-safe.Checklist