fix: clamp set_max_stack_size to avoid QuickJS stack limit underflow#678
Merged
richarddd merged 1 commit intoDelSkayn:masterfrom Apr 27, 2026
Merged
Conversation
richarddd
force-pushed
the
fix/max-stack-size-overflow
branch
from
e2a6d8a to
64fdaaa
Compare
Sytten
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #437
Description of changes
Runtime::set_max_stack_sizenow clamps its argument to a safe maximum so QuickJS'sstack_top - stack_sizesubtraction cannot underflow when callers pass values likeusize::MAX.Checklist