Reject JsClass types as class fields; guide users to Class<'js, T>#677
Merged
richarddd merged 1 commit intoDelSkayn:masterfrom Apr 23, 2026
Merged
Conversation
richarddd
force-pushed
the
fix/nested-class-field-clone
branch
from
671f0d9 to
1849313
Compare
richarddd
force-pushed
the
fix/nested-class-field-clone
branch
from
1849313 to
057147c
Compare
Sytten
approved these changes
Apr 23, 2026
Collaborator
Sytten
left a comment
Sytten
left a comment
There was a problem hiding this comment.
Not really a fan of the implementation that adds useless code but I dont see a better way.
Collaborator
Author
|
This is a bit hacky but wont affect build if you avoid this pattern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if available)
Fixes #532
Description of changes
#[rquickjs::class]fields typed directly as aJsClasssilently dropped nested mutations because the generated getter cloned the value and wrapped the clone in a fresh class instance. Now such fields produce a clear compile error (E0277via#[diagnostic::on_unimplemented]) directing users to wrap the field inClass<'js, T>to share the underlying cell. Implemented with autoref-specialization: aJsClassFieldCheck<T>helper whose inherentcheckmethod is bounded on an unimplementable marker traitNotAJsClassFieldwhenT: JsClass, and otherwise falls back to a trivial trait impl.Checklist