Repository navigation
Faster tool processing - #7
Merged
Merged
Conversation
Contributor
|
Preview of d3ae04d: https://fix-performance.ream-bqb.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tools were slow on big files everywhere (the same timings locally and on Cloudflare): every preview started a new worker and decoded the file again, and our pure-JS codecs and some pixel loops were slow on big photos.
Runs
Codecs (
appCodec)Platform.decodeJpegand writes them through the codec; grey stays ours. PDF to image writes JPG through the codec.Engine
stitchusesoverlay(Merge images 0.9 s -> 0.3 s).pngPredictorwith one loop per filter type (PNG decode 12 MP 519 -> 351 ms; also PDF streams).Convert image on a 48 MP photo, changing Save as: 7 to 11 s -> 1.3 to 1.8 s.
Checks
pngPredictoragainst the PNG definition.