Repository navigation
Skip the release when the version isn't new - #19
Merged
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A merge into
mainthat keeps the version of the last release is not a release, so it no longer deploys production, tags, creates a GitHub Release or pushes the Docker image. A docs-only change can now reachmainwithout a version bump.Type of Change
Related Issues
Closes #
Related to #
Changes Made
scripts/release.ts: newpendingcommand (printstruewhenv<version>isn't tagged yet).checknow passes, with a message, when the version is already released; it still fails for a new version that is older than the latest release or has noCHANGELOG.mdsection..github/workflows/web.yml:checkexposes areleaseoutput frompending; theproductionjob only runs when it istrue. Typecheck, tests, the build and the Docker check still run on every pull request and push.docs/deploy.md,AGENTS.md: describe the new behaviour.Screenshots (if applicable)
None.
Testing
Unit Tests
E2E Tests
Manual Testing
node scripts/release.ts pendingon a checkout whose version is tagged printsfalse.node scripts/release.ts checkin the same state exits 0 with "already released".mainshould showcheckgreen andproductionskipped.Checklist
Additional Notes
A real release still needs a higher version and a
CHANGELOG.mdsection.