feat(parser): set fix_available on GitHub Vulnerability parser#14943
Open
jsayerascb wants to merge 1 commit into
Open
feat(parser): set fix_available on GitHub Vulnerability parser#14943jsayerascb wants to merge 1 commit into
jsayerascb wants to merge 1 commit into
Conversation
Populate fix_available from firstPatchedVersion in the GraphQL response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Populate fix_available from firstPatchedVersion in the GraphQL response.
We don't want to waste your time, so if you're unsure whether your hypothetical enhancement meets the criteria for approval, please file an issue to get pre-approval before beginning work on a PR.
Learn more here: https://github.com/DefectDojo/django-DefectDojo/blob/master/readme-docs/CONTRIBUTING.md#submission-pre-approval
Description
Populate fix_available from firstPatchedVersion in the GraphQL response.
Test results
Unit tests added
test_parser_version(existing test, extended):finding.fix_available == Truewhen the GraphQL response contains"firstPatchedVersion": {"identifier": "6.0.0"}test_parse_no_fix_available(new test):github-1-vuln-no-fix.jsonwith"firstPatchedVersion": nullfinding.fix_available == FalseEdge cases verified manually
firstPatchedVersionkey missing entirely from the response →fix_available = FalseDocumentation
Please update any documentation when needed in the documentation folder)
Checklist
This checklist is for your information.
dev.dev.bugfixbranch.Extra information
Please clear everything below when submitting your pull request, it's here purely for your information.
Moderators: Labels currently accepted for PRs:
Contributors: Git Tips
Rebase on dev branch
If the dev branch has changed since you started working on it, please rebase your work after the current dev.
On your working branch
mybranch:In case of conflict:
When everything's fine on your local branch, force push to your
myOriginremote:To cancel everything:
Squashing commits
pickbyfixupon the commits you want squashed outpickbyrewordon the first commit if you want to change the commit messageForce push to your
myOriginremote: