Fixed some minor bugs in play.py#31
Open
Homerain wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original play.py attempted to implement a complex phase trajectory visualization but was missing the required variables and functions (e.g., for the M20), leading to runtime errors. This version replaces it with a simplified pure trajectory drawing approach, initializes only the minimal necessary variables, and works correctly (e.g., for the M20; when playing in multi‑environment settings, trajectory tracking is displayed only on one environment's robot to avoid visual clutter).
At this stage, the priority is to ensure that training and playback work properly. Therefore, this modification focuses on that goal. Other related features can be added later by overwriting this file once the original contributor has completed their implementation.
Before the next official update, please verify that the code runs without errors and check that comments are consistent in language.