-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/update docs #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
882bf63
Refactor actor spawning methods and streamline actor system traits
reiase 37ede15
Refactor actor reference handling and enhance message serialization o…
reiase 423febe
Refactor ActorLifecycle to use ActorId for watcher management
reiase bb307f0
Enhance Actor ID handling and update dependencies
reiase 509bfac
Enhance actor proxies and refactor message handling
reiase 7316616
Refactor StorageManager to utilize remote methods and improve message…
reiase b4c2266
Refactor error handling and enhance error types in Pulsing actor system
reiase 31115b2
Enhance Ray stress test script and performance comparison report
reiase 18928df
Enhance documentation with new communication patterns and error handl…
reiase File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check notice
Code scanning / CodeQL
Unused local variable Note test
Copilot Autofix
AI 23 days ago
In general, when a local variable is assigned but never used and the right-hand side has no side effects, either remove the variable or rename it to clearly indicate that it is intentionally unused. Here, the assignment
item = await refboth awaits theObjectRef(which is required to realize the stream elements and surface any exceptions) and binds the result toitem. The await itself is needed, but the bound name is not. To preserve behavior while satisfying the unused-variable rule and keeping the code illustrative, we should keep theawait refcall but bind it to a deliberately unused name.The best minimal fix is to rename
itemon line 286 to something like_item(which containsunused-style semantics via the leading underscore convention) so that CodeQL recognizes it as intentionally unused, without altering any other logic. Concretely, inbenchmarks/large_scale_stress_test_ray_single.py, insideStressTestClient.send_stream_request, change the lineto
No imports or additional definitions are needed for this change.