Repository navigation
Compose destructive ref policies and keep quorum executable - #36
Draft
Deep-Sixed wants to merge 4 commits into
Draft
Deep-Sixed wants to merge 4 commits into
Deep-Sixed wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two governance-composition findings from the review after #21/#27.
Ref-level policies compose
A destructive update to a protected ref now produces both applicable operations:
protected_ref_updateandforce_updateprotected_ref_updateandref_deleteThis prevents a protected-ref policy from masking stricter per-operation thresholds, roles, or quorum settings.
Quorum preserves an executor
When quorum mode is enabled and the requester is itself eligible to vote, the calculated quorum leaves one eligible agent outside the required yes-vote set. This prevents requester voting plus separation of duties from requiring every possible requester/executor to approve and then forbidding all of them from carrying the operation out.
An explicit fixed
--thresholdremains a floor and may still require unanimity. The existing invariant that an agent who voted yes cannot execute that approval remains unchanged.Regression coverage
Validation
On Friday's box:
ruff check src tests: cleanpyright: 0 errorspython -m pytest tests -q: 283 passed