Repository navigation
Compose ref policies and preserve quorum executor separation - #35
Merged
Merged
Conversation
Deep-Sixed
marked this pull request as ready for review
September 30, 2026 08:07
Deep-Sixed
added a commit
that referenced
this pull request
Sep 30, 2026
# Conflicts: # README.md # src/quorumgit/gate.py # src/quorumgit/git_objects.py # tests/test_approval_authority.py # tests/test_authorization_binding.py
Deep-Sixed
pushed a commit
that referenced
this pull request
Sep 30, 2026
Resolve the README conflict by keeping the consolidated Upgrading section and folding main's new 010 (protected ref full names) and 011 (quorum consumer separation) notes into it in migration order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SHGwY6PLGwr7kQY63qQGq6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two remaining governance findings from the review of main after #21/#32.
1. Protected ref rules now compose with force/delete rules
A protected ref previously took precedence over
force_updateandref_delete, so stricter per-operation policies for force pushes and deletions were skipped on protected refs.Now ref-level operations are additive:
protected_ref_updateprotected_ref_update+force_updateprotected_ref_update+ref_deleteThe existing all-or-nothing multi-approval path handles the composed operations.
2. Quorum execution never counts the executor's own vote
Fixed-threshold behavior is unchanged: an approver cannot consume its own approval.
Under quorum policy, if the consumer also voted yes, that consumer is removed from both:
Consumption succeeds only if the other currently eligible approvers still satisfy 2/3 + 1 (and the fixed threshold floor). This prevents small quorums from becoming impossible to execute without allowing self-authorization.
Migration
011_quorum_consumer_separation.sql:approval_effective_policyapproval_eligible_agentsRegression coverage