Repository navigation
Number staged candidates past every bound version - #25
Open
Deep-Sixed wants to merge 2 commits into
Open
Deep-Sixed wants to merge 2 commits into
Deep-Sixed wants to merge 2 commits into
Conversation
apply_updates always named a candidate active+1, but /admin/validate binds each version to its first checksum permanently (and persists the binding). Stage, validate, then stage a different edit produced the same version with a new checksum, and every later stage was refused with 422 "already bound" until the abandoned candidate was reproduced exactly. Staging now numbers past every version the lifecycle has bound under the active version's date. Also turns a non-finite number (JSON Infinity) in a numeric field into a 422 instead of an uncaught OverflowError 500. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lj4neZ1qzw7tpiCJ8oedxJ
Keeps the test valid once loopback trust also requires a local Host. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lj4neZ1qzw7tpiCJ8oedxJ
Owner
Author
|
The fix is at the source: #24's single commit was amended to use Generated by Claude Code |
Deep-Sixed
marked this pull request as ready for review
October 11, 2026 00:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
apply_updatesalways named a staged candidate active + 1./admin/validate, however, binds each version to its first checksum permanently, and the binding is persisted inconfig_revisions.As a result, stage → validate → stage a different edit produced the same version with a new checksum, and validation failed with 422 "already bound". Every later stage from the console collided the same way, across restarts, until the abandoned candidate was reproduced byte for byte.
Separately, a non-finite number (JSON
Infinity) in a numeric field raised an uncaughtOverflowError, which returned a 500.Change
ConfigLifecycle.known_versionsexposes every bound version./admin/config/stagepasses those versions toapply_updates(..., taken_versions=...), which numbers the candidate past the highest.Nunder the active version's date.OverflowErroris now aValueError, so the endpoint answers 422.Tests
Infinity→ 422.🤖 Generated with Claude Code
https://claude.ai/code/session_01Lj4neZ1qzw7tpiCJ8oedxJ
Generated by Claude Code