Repository navigation
Take startup bindings from the boot file, not the restored revision - #22
Open
Deep-Sixed wants to merge 1 commit into
Open
Deep-Sixed wants to merge 1 commit into
Deep-Sixed wants to merge 1 commit into
Conversation
After a restart, create_app read server/auth/SSO/authentik/telemetry bindings from the revision restored out of SQLite while cli.py bound the listen host and port from the boot file. An operator who changed the file to a public host plus an api token and restarted got a public listener enforcing the old revision's (absent) token. Bindings now come from the boot document; routing policy still follows the restored active revision, and a mismatch is logged at startup. The admin fusion status now reports the active revision rather than boot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lj4neZ1qzw7tpiCJ8oedxJ
Owner
Author
|
The fix is at the source: #24's single commit was amended to use Generated by Claude Code |
Deep-Sixed
marked this pull request as ready for review
October 11, 2026 00:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After a restart,
SqliteControlPlane.bootstraprestores the last active revision from SQLite, andcreate_appreadboot_config = lifecycle.active.configfrom it. That coversserver.api_token_env,admin_token_env,admin_sso,authentik,telemetry,public_docsandadmin_config_roots. Meanwhilecli.pytakes the listen host and port from the boot file.Reproduced: v1 =
host: 127.0.0.1, no api token (a valid config). The operator edits the file tohost: 0.0.0.0+api_token_envand restarts. The process then listens on0.0.0.0while enforcing v1's absent token, and an unauthenticated remote client got 200 on/v1/chat/completions.Change
boot_config = document.config: the startup settings come from the same documentcli.pybinds from. Routing policy still follows the restored active revision./admin/statusfusionnow reports the active revision instead of the boot config.docs/persistence.mddocuments the rule.Tests
tests/test_boot_bindings.pyfails onmainand passes here.🤖 Generated with Claude Code
https://claude.ai/code/session_01Lj4neZ1qzw7tpiCJ8oedxJ
Generated by Claude Code