Skip to content

fix: delay tooltip icon fallback #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
77x7 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: delay tooltip icon fallback #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions package/contents/ui/ToolTipInstance.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,10 +426,10 @@ Item {
animated: false
visible: valid

// FIX: Hide ONLY when PipeWire thumbnail is ACTUALLY READY.
// If loader is active but item is null or not ready, keep icon visible.
// Avoid flashing the fallback while the PipeWire stream starts normally.
property bool thumbnailReady: pipeWireLoader.active && pipeWireLoader.item && pipeWireLoader.item.hasThumbnail
opacity: thumbnailReady ? 0 : 1
property bool fallbackDelayElapsed: false
opacity: thumbnailReady || !fallbackDelayElapsed ? 0 : 1

anchors.fill: parent
anchors.margins: Kirigami.Units.gridUnit
Expand All @@ -442,16 +442,16 @@ Item {
}
}

SequentialAnimation {
running: true
PauseAnimation { duration: Kirigami.Units.humanMoment }
NumberAnimation {
id: showAnimation
duration: Kirigami.Units.longDuration
easing.type: Easing.OutCubic
property: "opacity"
target: realIconItem
to: 1
Timer {
interval: Kirigami.Units.humanMoment
running: !realIconItem.thumbnailReady && !realIconItem.fallbackDelayElapsed
onTriggered: realIconItem.fallbackDelayElapsed = true
}

Connections {
target: root
function onCurrentWinIdChanged(): void {
realIconItem.fallbackDelayElapsed = false;
}
}
}
Expand Down