23 configuration assistance

[JaszczurGra]

Test's don't include teseting if the version is lower 3.11+ for toml imports and require yaml installed idk how to add it temporarily

[Dawid64]

Reformat code - do not use hadouken indentation.
Why is there a type hint validation? I believe this is already implemented in other decorator (type hints_validation) or something like that

[Dawid64]

I also like creating one liners, but nesting if statements in such a way makes it's harder to read.
Also

if condition:
    logic()
else:
    raise()

is terrible practice, you should avoid it at all cost, try using

if not condition:
   raise()
logic()

it makes logic not nested and it avoids hadouken indentation

[JaszczurGra]

So does putting a _open_file function count as nested and should be moved outside of the decorator?

[Dawid64]

Overall code should not be nested, and it's unrecommended to make lines with size greater than 100, in my opinion 140 should be hard limit, but it's rather personal, I recommend using formatter, to avoid such problems, also avoid nesting. Logic may work fine, but it's unreadable. Feel free to take a look at: https://www.youtube.com/watch?v=CFRhGnuXG-4

[Dawid64]

Also minor change, you may avoid Polish names for integrity

[JaszczurGra]

Where were polish names?

[JaszczurGra]

Reformat code - do not use hadouken indentation. Why is there a type hint validation? I believe this is already implemented in other decorator (type hints_validation) or something like that

So I wanted to have better logging so that it tells you if the wrong typehint was in the config or in the function call.
(Could add validate typehint ass the decorator before wraps to first check the args coming from the function call and then when returning function for configuration typehint checking if wanted)

As well as passing the config attributes as args if they don't have default value in the function definition and not as kwargs always but idk if it's necessary?

[JaszczurGra]

imports could be added at the beginning of the file (run only initilization and store the import success value for yaml as constant bool), that would make the code less nested as well as could reduce the runtime if opening yaml file would be required multiple times

[Dawid64]

I added few changes, with them looks all good to me, if you don't agree with them feel free to git reset --hard HEAD~3

[JaszczurGra]

Looks good , but one more personon needs to approve