Update automatic tests to include diffrent os and python versions.

[adamtms]

No description provided.

[adamtms]

The testing script has to be updated to support windows

[Dawid64]

Any ideas how to do so?

[adamtms]

Any ideas how to do so?

I think that the only line that fails is the one that checks if requirement.txt is present
Not sure if the best way would be to turn off the check, or try to do it using the github action config.

[Dawid64]

I think that the only line that fails is the one that checks if requirement.txt is present Not sure if the best way would be to turn off the check, or try to do it using the github action config.

I believe it's not the only issue:

Version 3.7 was not found in the local cache
Error: Version 3.7 with arch arm64 not found

so it also needs to be disabled
And I think that it may be better to run windows separately - probably easier to setup, and windows as inferior operating system is more likely to fail, and information about either only windows failed or everything may be important

[Dawid64]

This is also an interesting problem, I think there will actually be more work with that issue (unfortunately)

[adamtms]

This is also an interesting problem, I think there will actually be more work with that issue (unfortunately)

It may be possible that we should just give more time as buffer. I do not think that sleep guarantees immediate wake up after duration, just that it will stop sleeping if resources are available.

[adamtms]

Fun fact literals werent added until python 3.8 and we use them in one of the decorators.
@Dawid64 Any idea of a good replacement?

[adamtms]

I think that the only line that fails is the one that checks if requirement.txt is present Not sure if the best way would be to turn off the check, or try to do it using the github action config.

I believe it's not the only issue:

Version 3.7 was not found in the local cache
Error: Version 3.7 with arch arm64 not found

so it also needs to be disabled And I think that it may be better to run windows separately - probably easier to setup, and windows as inferior operating system is more likely to fail, and information about either only windows failed or everything may be important

3.7 is just not supported on newest macos since it supports only apple silicon, and python 3.7 was never developed for these new chips.

[Dawid64]

so it also needs to be disabled And I think that it may be better to run windows separately - probably easier to setup, and windows as inferior operating system is more likely to fail, and information about either only windows failed or everything may be important

3.7 is just not supported on newest macos since it supports only apple silicon, and python 3.7 was never developed for these new chips.

yep, so we need to use other grid

[adamtms]

so it also needs to be disabled And I think that it may be better to run windows separately - probably easier to setup, and windows as inferior operating system is more likely to fail, and information about either only windows failed or everything may be important

3.7 is just not supported on newest macos since it supports only apple silicon, and python 3.7 was never developed for these new chips.

yep, so we need to use other grid

I just changed macos version for this one specific python version

[Dawid64]

Fun fact literals werent added until python 3.8 and we use them in one of the decorators. @Dawid64 Any idea of a good replacement?

Ehh, we need to choose "Readability over Compatibility" otherwise.
Personally I think as for a minor library, we should aim to be the most compatible as possible to not limit user possibilities.
But the true is that support for Python 3.7 ended over year ago https://devguide.python.org/versions/ . And also for me readability counts, but this is group decision, so I wait for votes. (I vote to support python 3.9+, as it's still supported version, maybe 3.8+)

[adamtms]

Fun fact literals werent added until python 3.8 and we use them in one of the decorators. @Dawid64 Any idea of a good replacement?

Ehh, we need to choose "Readability over Compatibility" otherwise. Personally I think as for a minor library, we should aim to be the most compatible as possible to not limit user possibilities. But the true is that support for Python 3.7 ended over year ago https://devguide.python.org/versions/ . And also for me readability counts, but this is group decision, so I wait for votes. (I vote to support python 3.9+, as it's still supported version, maybe 3.8+)

Yea i think 3.8+ is a good idea. From what i remember you cant even create an environment with 3.7 using conda or download an official docker container with this version.

[Dawid64]

It's under review, so I will request changes as it will probably more complex than current solution

[adamtms]

I tested removing concurrency and it didnt work. I think we could try to change the testing function to not release any cores while sleeping.

[JaszczurGra]

If I understand correctly the testing of the difrent os is now mainly working? Or does it test when I pull the repository and then checks on my PC? All the other test connected to grid search work on windows :)