Repository navigation
fix(votes): auto-hide success banner after 10 s - #118
Merged
Merged
Conversation
sessionSubmitted resets via useEffect timeout so the "Verfügbarkeit gespeichert" banner disappears ~10 s after submit, even if the user navigates away and back within the same SPA session. Co-Authored-By: AI Agent <noreply@agent>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sessionSubmittedis React state local to VotePage. Since the SPA doesn't always unmount VotePage on navigation (e.g. switching to Find and back), the "Verfügbarkeit gespeichert" banner stayed visible indefinitely within the same session.Fix
A
useEffectwatchessessionSubmittedand clears it after 10 s viasetTimeout. The cleanup function cancels the timer if the component unmounts early, so there are no stale state updates.Behaviour after fix
https://claude.ai/code/session_01Y9SKqkQP7DxXSe1TnXynin
Generated by Claude Code