fix(identity): bind candidate_name to fictional profile, off MCP surface - #21
Merged
Conversation
The four md-generator tools (strategic_playbook, application_summary, interview_prep, quick_reference) exposed candidate_name as a free MCP input, letting the agent compose the candidate identity from its own memory -- a PII risk: real identities instead of the fictional Robin Mercier. Remove the channel on all four: candidate_name leaves the input surface (JSON schema properties + required AND the tool-description prose) and is injected from CANDIDATE_PROFILE at payload composition, where the profile wins over any caller value. Single binding location, destined to become the deployment MCP resource like sender_*. cover_letter was already bound; unchanged. Add falsify-first structural floor guards and an observed end-to-end test rendering all five deliverables.
David-BS
added a commit
that referenced
this pull request
Jun 28, 2026
Couples manifest.version and chain_core.SERVER_VERSION so the frozen-server T0 parity assert (serverInfo.version == manifest) stays green. Carries the c1 identity-binding fix (PR #21) under a distinct version, separating this build from the pre-c1 public 0.2.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four md-generator tools (strategic_playbook, application_summary, interview_prep, quick_reference) exposed candidate_name as a free MCP input, letting the agent compose the candidate identity from its own memory -- a PII risk: real identities instead of the fictional Robin Mercier.
Remove the channel on all four: candidate_name leaves the input surface (JSON schema properties + required AND the tool-description prose) and is injected from CANDIDATE_PROFILE at payload composition, where the profile wins over any caller value. Single binding location, destined to become the deployment MCP resource like sender_*. cover_letter was already bound; unchanged.
Add falsify-first structural floor guards and an observed end-to-end test rendering all five deliverables.