v1.4: preserve consecutive livery parent/child transforms - #30
Draft
Datamining00 wants to merge 4 commits into
Draft
v1.4: preserve consecutive livery parent/child transforms#30Datamining00 wants to merge 4 commits into
Datamining00 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix derivative of
v1.4-parser-structural-audit.Root cause confirmed by the ownership trace
The supplied Parent Ownership Diagnostic shows that the earlier bare-parent recovery at offset 271968 is now correct: it owns exactly two child groups (272009 and 272321). However, the remaining central
XANADU / THE NEW WORLDartwork is a different parser failure.The raw stream around offset 269788 contains:
(-360.5, -31.0, 0.9000001, 3.5);00 02 00 01 00 00 00 03with child transform(0.0125732, 2.4793174, 0.05000036, 0);Unlike the previous bare-parent case, this parent is already recognized by the pinned decoder as a normal zero-marker livery transform. The bug is that
walk_step()stores only onepending_transform; when the extended child transform follows, it replaces the already-recognized parent instead of preserving parent/child ownership.The result is structurally valid layer counts but a wrong GroupNode tree, which explains why Structural Audit v2 correctly reported
unframed_transform_candidate_count = 0while the artwork was still misplaced.Fix
Adds a narrow consecutive-transform grammar rule:
00;00 02 00 01 00 00 00 03;No car ID, section name, phrase, creator, source offset, or coordinate is hard-coded. No layer reversal, mask rule, source-offset normalization, or renderer/projection behavior is changed.
Validation
5a386de6a7f61b27e5cfdbbbb5606685e8fda5fe4356856f73ae60f63af595b1.fbf532baebfaeb72b0316070010031e1aa1054f2a3e1d7d72644f7534607bea6.Validation target
On the supplied
Livery_0343Right section, this should move the currently central XANADU/THE NEW WORLD group family under its real parent transform instead of leaving it around the character face.This PR stays draft until the real livery is visually checked.