v1.4: recover bare parent transform pairs in C_livery - #27
Draft
Datamining00 wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix derivative of
v1.4-baseline-warning-render, based on the real-save raw transform trace fromLivery_0343_20260812130034 / C_livery.Proven root cause
Immediately before the anomalous Right-side text group, the raw stream contains a sane 16-byte transform (
x=-373.5,y≈4.0,scale=1,rotation=0) followed directly by the extended livery child-transform marker00 02 00 01 00 00 00 03.The pinned decoder did not recognize that bare parent transform. It therefore walked through those 16 bytes as control bytes, leaked an internal
0xfffloat byte intopending_flags, and then attached the following text groups directly to the Right section root. This explains both the observedflags=0xffanomaly and the missing outer placement transform.The next two child groups are the rear text groups previously identified as
FLAMEHAZEandTHOSEWHOHUNTANDDESTROY; treating the bare transform as the existing two-child implicit transform-pair grammar moves those groups to the rear body location instead of over the character.Fix
read_livery_transformparser independently proves the following child group boundary.implicit_bare_transform_pair, matching the decoder's existing implicit transform-pair ownership model.Validation
740fed2d1e87a3e3dab1ef413aa91d9d71af5de87753ef3b2a4dc839ef210710.52e70e4d4996a00f178adf052b9407d989aceca68365f79b77d191529e33abc6.This PR remains draft until the supplied real livery is visually validated with the fix-test EXE.