v1.4: diagnose and fix C_livery populated-section boundary drift - #25
Draft
Datamining00 wants to merge 11 commits into
Draft
v1.4: diagnose and fix C_livery populated-section boundary drift#25Datamining00 wants to merge 11 commits into
Datamining00 wants to merge 11 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostic/fix derivative of
v1.4-baseline-warning-render.Confirmed diagnostic result
source_offsetnormalizer did not move any layers in the Fluorite AKE Left/Right sections.Boundary finding
For sample
Livery_3761_20260818134954 / C_livery, structurally valid 32-byte placements occur at populated-section boundaries where the pinned decoder unconditionally advances byLIVERY_POPULATED_REMNANT_SIZE(18 bytes). That skip causes the next section's first placement to be missed and shifts ownership of later placements across the boundary while counts can still appear correct.Observed boundary pattern:
Fix under test
livery_section_boundary_fix_patch.pysuppresses the legacy 18-byte populated remnant skip only when all of the following are true:No layer reversal is used. No source-offset sorting rule is changed. No Car ID or section name is hard-coded.
Validation
FH6 Assistant v1.4 Section Boundary Fix Test.exeartifact is built for real-save visual validation.This PR remains draft until the Fluorite AKE Left-side render is validated against the in-game/reference appearance.