multi row reorder enhancement #17

LPmaverick · 2017-03-21T15:13:33Z

allow for multiple rows to be reordered at once
new default option, placeholder
includes test html

- allow for multiple rows to be reordered at once - includes test html

DataTables · 2017-03-22T16:29:35Z

This looks like a fantastic enhancement - thank you.

Couple of things:

Are you happy for this to be included under the MIT license?
I'm not sure how well this will work with the Editor integration - I'll check that out
The demo HTML should really be an XML file similar to the others in the examples directories. That way the demo HTML doesn't need to be committed into every file.

The XML examples can be built using the method described here.

LPmaverick · 2017-03-22T17:28:01Z

1. yes 2. hopefully it will. I tried to keep it similar to how the rest of the logic was handled. 3. Yeah sorry wasn't sure how you were doing all that. Haven't worked with much outside of basic HTML/JSP.

…

On Wed, Mar 22, 2017 at 11:29 AM, Allan Jardine ***@***.***> wrote: This looks like a fantastic enhancement - thank you. Couple of things: 1. Are you happy for this to be included under the MIT license? 2. I'm not sure how well this will work with the Editor integration - I'll check that out 3. The demo HTML should really be an XML file similar to the others in the examples directories. That way the demo HTML doesn't need to be committed into every file. The XML examples can be built using the method described here <https://datatables.net/manual/development/build>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AY1_bxviCwlffq6e59rDOC9G3f24-UP9ks5roUxygaJpZM4Mj9EH> .

LPmaverick · 2017-05-02T19:46:18Z

Did this ever get approved, tested, and put into build? On Wed, Mar 22, 2017 at 12:27 PM, jason gordon <jr42.gordon@gmail.com> wrote:

…

1. yes 2. hopefully it will. I tried to keep it similar to how the rest of the logic was handled. 3. Yeah sorry wasn't sure how you were doing all that. Haven't worked with much outside of basic HTML/JSP. On Wed, Mar 22, 2017 at 11:29 AM, Allan Jardine ***@***.***> wrote: > This looks like a fantastic enhancement - thank you. > > Couple of things: > > 1. Are you happy for this to be included under the MIT license? > 2. I'm not sure how well this will work with the Editor integration - > I'll check that out > 3. The demo HTML should really be an XML file similar to the others > in the examples directories. That way the demo HTML doesn't need to > be committed into every file. > > The XML examples can be built using the method described here > <https://datatables.net/manual/development/build>. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#17 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AY1_bxviCwlffq6e59rDOC9G3f24-UP9ks5roUxygaJpZM4Mj9EH> > . >

DataTables · 2017-05-02T20:03:38Z

Not yet, sorry. I've not managed to find time to review it and its implications properly yet. It is still in my inbox so I will get around to it though.

stefanchiriac · 2017-12-27T19:54:25Z

@DataTables There are any news about merging this pull request, or it has any chances to be merged any time soon?

DataTables · 2018-06-04T15:51:53Z

Hi - sorry I've been so long with this one. I've just tried it out and it looks great. I'm not going to merge it in immediately as there are two things I'd like to modify a little:

It makes Select a hard dependency for RowReorder.
When the drag is started to move the rows, it jumps the position of the rows, rather than keeping them in place.

That said, this will be a really excellent addition and thanks for contributing it @LPmaverick! Because its a new feature I'm going to publish 1.2.4 without it, but when I get a chance I'll circle back and make those changes for 1.3.0.

LPmaverick · 2018-06-19T17:49:07Z

The reason for the jumping is to group all of the selected rows together if they happen to be spread out, and in the same order as they appear in the list.

LPmaverick · 2019-07-01T14:53:40Z

How is this coming along? This is referring to this forum update.

DataTables · 2019-07-01T19:33:25Z

I'm afraid I've not yet made time to look into this PR. Apologies, its one of those things that keeps slipping away from me with other things going on. It is here though, so I will get to it!

Hedva · 2019-07-04T09:51:44Z

Do you have any expected date when this wil be implemented? Because right now I'm not sure what to do. Just wait until release, or update the code myself so at least I can use it. I prefer option 1, but if it takes another couple of months I'll go for option 2.

DataTables · 2019-07-04T10:00:37Z

I'd go for option 2 at the moment. My support backlog at the moment is enormous!

paciox · 2024-10-28T15:08:28Z

WHY THE HECK THIS ISN'T MERGED STILL?
MOVE YOUR LAZY HEAD

You had an "normous support backlog" for 7 years?????????

AllanJard · 2024-10-28T15:17:59Z

I haven't prioritised it over other work I've been doing. It can't be merged at the moment, but you are welcome to update it and patch to address the issue about it making Select a hard dependency, which I don't want at this time for this extension.

paciox · 2024-10-28T15:47:00Z

I haven't prioritised it over other work I've been doing. It can't be merged at the moment, but you are welcome to update it and patch to address the issue about it making Select a hard dependency, which I don't want at this time for this extension.

Well, time to prioritise it, since every major serious grid implementation in commercial/freeware frameworks supports it, or at least provide a working sample.
What was the datatable version at the time?
Can we have a working jsfiddle of this?

https://cdn.datatables.net/1.10.17/

I can find this and "I see DataTables CDN files for DataTables 1.10.17. This software was originally released on ." with a missing date....
What version of datatable it was? Where we can find it?

but you are welcome to update it and patch to address the issue

Me? Lol.... I didn't knew I was a maintainer of this library
You should do it. Moreover it gives weird unintelligible errors that requires hours of deep debugging for who isn't familiar with the inner code of datatables library. I have a work and no time to waste

Anyway it's fine for me to get it working on a older library,
Probably knowing which version of datatables was running in 2017 + using same jquery version + the js in that pull request might do the trick... so what version it was?

AllanJard · 2024-10-28T15:58:17Z

It looks like 1.10.14 around that time: https://cdn.datatables.net/1.10.14/ .

Of course you aren't the maintainer of the library - I am. However, it is open source and if it is a feature you need, then you are welcome to implement it or pay someone to do so.

paciox · 2024-10-28T16:02:25Z

It looks like 1.10.14 around that time: https://cdn.datatables.net/1.10.14/ .

Of course you aren't the maintainer of the library - I am. However, it is open source and if it is a feature you need, then you are welcome to implement it or pay someone to do so.

Does it have a single min file or I have to add every file listed there?
The newest version have a single file to add

Trying to make it work here:
https://jsfiddle.net/b91k8ors/1/

AllanJard · 2024-10-28T16:04:19Z

Are the two core DataTables files you'll want. Plus jQuery (I'd imagine the latest of their 1.x series should be okay). Plus the patches RowReorder.

paciox · 2024-10-28T16:15:20Z

cdn.datatables.net/1.10.14/css/jquery.dataTables.css

cdn.datatables.net/1.10.14/js/jquery.dataTables.js

Are the two core DataTables files you'll want. Plus jQuery (I'd imagine the latest of their 1.x series should be okay). Plus the patches RowReorder.

https://jsfiddle.net/zvto2mx5/1/

Does not work.

"79:28 Uncaught TypeError: $(...).DataTable is not a function"

Any idea? seems it doesn't get jquery or smth?

The cdns are the ones you suggested

AllanJard · 2024-10-28T16:19:48Z

You need to load jQuery before DataTables. In JSFiddle you can click and drag the jQuery resource and put it to the top of the list.

paciox · 2024-10-28T16:39:41Z

You need to load jQuery before DataTables. In JSFiddle you can click and drag the jQuery resource and put it to the top of the list.

Stupid me.
https://jsfiddle.net/zvto2mx5/3/

Now i fixed that and all the other errors it gave, but it seems to do nothing.
Any idea? no errors whatsoever

AllanJard · 2024-10-28T16:54:16Z

The github file being loaded for the JS is an HTML page. Firefox shows me:

The resource from “https://github.com/LPmaverick/RowReorder/blob/master/js/dataTables.rowReorder.js” was blocked due to MIME type (“text/html”) mismatch (X-Content-Type-Options: nosniff).

Even using their raw option isn't enough. Instead, if I copy / paste it into the JSFiddle and also include Select from around that era, then it does something: https://jsfiddle.net/re8bjLpu/ .

paciox · 2024-10-29T08:12:28Z

The github file being loaded for the JS is an HTML page. Firefox shows me:

The resource from “https://github.com/LPmaverick/RowReorder/blob/master/js/dataTables.rowReorder.js” was blocked due to MIME type (“text/html”) mismatch (X-Content-Type-Options: nosniff).

Even using their raw option isn't enough. Instead, if I copy / paste it into the JSFiddle and also include Select from around that era, then it does something: https://jsfiddle.net/re8bjLpu/ .

Wow, I haven't tought of checking out that one. Good spot!
Thanks, looks like it's working now, a bit rough in how it works but gets the job done

Thanks for now. If it's not too much work I will try to take a look into implementing in the new datatables lib and make a pull.
Can't promise anything though, at least for now

piradoiv · 2025-03-19T15:31:29Z

@AllanJard other than the Select dependency concern, are you interested in a PR that is compatible with the current codebase? I'd like to get this feature merged in and I'm happy to help, if you want.

AllanJard · 2025-03-20T15:27:34Z

Possibly yes, it depends on how invasive the changes are? I also don't want to make Select a hard dependency for this plugin. That wouldn't be pulled in I'm afraid.

piradoiv · 2025-03-20T17:37:06Z

Perfect, I'll give it a try and create a new one as soon as possible.

LPmaverick added 2 commits March 21, 2017 10:07

multi row reorder enhancement

0649f65

- allow for multiple rows to be reordered at once - includes test html

forgot added default option

03168ed

paciox mentioned this pull request Oct 28, 2024

Multiple row reorder #31

Closed

piradoiv mentioned this pull request Mar 26, 2025

Add support for multi row reorder #32

Open

Uh oh!

multi row reorder enhancement #17

Are you sure you want to change the base?

multi row reorder enhancement #17

Uh oh!

Conversation

LPmaverick commented Mar 21, 2017

Uh oh!

DataTables commented Mar 22, 2017

Uh oh!

LPmaverick commented Mar 22, 2017 via email

Uh oh!

LPmaverick commented May 2, 2017 via email

Uh oh!

DataTables commented May 2, 2017

Uh oh!

stefanchiriac commented Dec 27, 2017

Uh oh!

DataTables commented Jun 4, 2018

Uh oh!

LPmaverick commented Jun 19, 2018

Uh oh!

LPmaverick commented Jul 1, 2019

Uh oh!

DataTables commented Jul 1, 2019

Uh oh!

Hedva commented Jul 4, 2019

Uh oh!

DataTables commented Jul 4, 2019

Uh oh!

paciox commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AllanJard commented Oct 28, 2024

Uh oh!

paciox commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AllanJard commented Oct 28, 2024

Uh oh!

paciox commented Oct 28, 2024

Uh oh!

AllanJard commented Oct 28, 2024

Uh oh!

paciox commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AllanJard commented Oct 28, 2024

Uh oh!

paciox commented Oct 28, 2024

Uh oh!

AllanJard commented Oct 28, 2024

Uh oh!

paciox commented Oct 29, 2024

Uh oh!

piradoiv commented Mar 19, 2025

Uh oh!

AllanJard commented Mar 20, 2025

Uh oh!

piradoiv commented Mar 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

paciox commented Oct 28, 2024 •

edited

Loading

paciox commented Oct 28, 2024 •

edited

Loading

paciox commented Oct 28, 2024 •

edited

Loading