Repository navigation
fix(envoy-gateway): verify controller pods by their real label - #42
Merged
Merged
Conversation
The post-install check selected app.kubernetes.io/name=envoy-gateway, which the controller pods never carry (they are control-plane= envoy-gateway, app.kubernetes.io/name=gateway-helm), so it always reported 0/0 pods and a 'may not be ready' warning. With pipefail, 'grep -c ... || echo 0' also printed 0 twice on no match. Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #40, found while upgrading poc-apps to v1.9.2 with the new script.
app.kubernetes.io/name=envoy-gateway, which Envoy Gateway controller pods don't have (control-plane=envoy-gateway,app.kubernetes.io/name=gateway-helm). It always waited 60s, reported 0/0 pods and printed a misleading "may not be fully ready" warning. Now usescontrol-plane=envoy-gateway.pipefail(added in fix(envoy-gateway): make module safe for upgrades, pin v1.9.2 #40),grep -c ... || echo "0"printed0twice when nothing matched; use|| true.The real readiness gate is the
kubectl rollout statusadded in #40, which passed on every step (poc-apps v1.7.5 → v1.8.5 → v1.9.2).Testing:
bash -n; selector returns the controller pod on poc-apps.Made with Cursor