Repository navigation
chore(k8s): remove unused cert-manager ReferenceGrant - #49
Merged
Merged
Conversation
allow-cert-manager-secrets let high-command Gateways reference cert-manager/wildcard-dataknife-ai-tls, a retired *.dataknife.ai wildcard (expired 2026-04-17). The Gateway uses its own cert-manager Certificate (high-command-gateway-https-dataknife-ai), so the grant is unused. Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
k8s/referencegrant.yaml(ReferenceGrantcert-manager/allow-cert-manager-secrets). It allowed Gateways inhigh-commandto referencecert-manager/wildcard-dataknife-ai-tls, the retired*.dataknife.aiwildcard, which expired on 2026-04-17 and is no longer renewed (gitops-core removed that automation).high-command-gateway's only listener (https-dataknife-ai, hc.dataknife.ai) uses the same-namespace Certificatehigh-command-gateway-https-dataknife-ai(valid until 2026-12-29), so nothing uses this grant.mcp-referencegrant.yaml(HTTPRoute to the MCP Service) is unaffected.The live object on prd-apps was applied by hand (CI only applies Deployments), so it gets deleted live after merge. Related: DataKnifeAI/gitops-core#9.
Made with Cursor