Repository navigation
fix: add build target to Makefile - #29
Merged
Merged
Conversation
- Remove git pull step that was causing merge conflicts - Add --force flag to git push to handle branch divergence - This allows GitHub to override GitLab branch when they diverge
- Add separate build stage with language-specific images (Go/Python/Node) - Fix docker login to use --username flag (per GitLab docs) - Build artifacts are passed to docker build stage via dependencies - Add DOCKER_TLS_CERTDIR for Docker-in-Docker support - Run 'make build' before docker build to prepare app assets
- Remove before_script auth generation code - Rely on DOCKER_AUTH_CONFIG GitLab group variable - Matches working pattern from proxmox-ve-mcp
The Makefile uses SHELL := /bin/bash which requires bash to be installed. Alpine Linux doesn't include bash by default, so add it to the apk add command.
Keep bash package in apk add command which is required by the Makefile.
Keep our changes: - Harbor proxy image (harbor.dataknife.net/dockerhub/library/golang:1.23-alpine) - bash package in apk add (required by Makefile)
Add 'build' target to Makefile that builds the Python package using python -m build. This allows CI to use 'make build' as intended. Changes: - Add 'build' target to Makefile (cleans and builds package) - Update .PHONY declaration to include 'build' - Update help text to include build target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 'build' target to Makefile that builds the Python package using
python -m build. This allows CI to usemake buildas intended.Changes:
buildtarget to Makefile (cleans and builds package)buildThis follows the same pattern as PR #22 in high-command-api.