Repository navigation
Separate poller service from API - #26
Merged
Merged
Conversation
The CI pipeline uses 'make build' but the Makefile didn't have a build target for Python projects. Error: make: *** No rule to make target 'build'. Stop. Changes: - Added build target that runs 'pip install --upgrade pip build' and 'python -m build' - Build depends on clean target to ensure fresh builds - Updated .PHONY declaration to include build - Updated help text to include build target
- Create unified entry point (src/main.py) with MODE environment variable - MODE=api: Runs read-only API server (app_readonly.py) - MODE=collector: Runs data collector/poller - Create app_readonly.py: Read-only API without collector/scraper - Create poller deployments (blue/green, scale 1) - Update API deployments to use MODE=api - Update Dockerfile to use unified entry point - Both services use same Docker image, configured via MODE env var Architecture: - Poller: 1 replica, writes to DB (uses PVC) - API: Read-only, can scale independently - Blue/Green deployment for both services - Solves PVC ReadWriteOnce limitation by separating write/read concerns
- Exclude src/main.py, src/poller.py, src/app_readonly.py from coverage - These are infrastructure/entry point files not directly unit tested - Entry points are tested indirectly through the actual application - Maintains 80% coverage requirement for directly testable code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates the data collection poller from the API service, allowing independent scaling and solving PVC ReadWriteOnce limitations.
Changes
src/main.py) with MODE environment variableMODE=api: Runs read-only API server (app_readonly.py)MODE=collector: Runs data collector/pollerapp_readonly.py: Read-only API without collector/scraperArchitecture