Repository navigation
fix: add build target to Makefile - #25
Merged
Merged
Conversation
- Add release stage that runs on main branch - Release creates tags automatically (v0.$CI_PIPELINE_IID) - Publish stage runs on any git tag - Deploy stage runs on semantic version tags only - Uses registry.gitlab.com/gitlab-org/cli:latest for release job
Fix YAML syntax error at line 22 by quoting the glob pattern *.egg-info/ to prevent YAML parser from interpreting * as an alias.
Keep the quoted glob pattern "*.egg-info/" which fixes the YAML syntax error.
The repository doesn't have a Makefile 'build' target, so 'make build' was failing. Replace with 'python -m build' which is the standard Python build command. Also replace 'make' package with 'build-essential' which provides the necessary build tools for Python packages.
Add 'build' target to Makefile that builds the Python package using python -m build. This allows CI to use 'make build' as intended. Changes: - Add 'build' target to Makefile (cleans and builds package) - Update .gitlab-ci.yml to use 'make build' instead of 'python -m build' - Add 'make' package back to CI dependencies - Update help text to include build target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI pipeline uses 'make build' but the Makefile didn't have a build target for Python projects.
Error:
make: *** No rule to make target 'build'. Stop.Changes:
pip install --upgrade pip buildandpython -m build