Repository navigation
fix: remove event_name check from push-to-gitlab job condition - #23
Closed
surrealwolf wants to merge 0 commit into
Closed
surrealwolf wants to merge 0 commit into
surrealwolf wants to merge 0 commit into
Conversation
surrealwolf
force-pushed
the
fix/push-to-gitlab-condition
branch
from
January 11, 2026 20:20
7f42e07 to
2a4da13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'Push to GitLab' job was being skipped on main branch when the workflow was triggered by
workflow_dispatchor other events (not justpush).Issue:
Job condition required
github.event_name == 'push', so it only ran on direct pushes, not manual triggers.Changes:
github.event_name == 'push'requirement from job conditionif: always() && needs.test.result == 'success' && github.ref == 'refs/heads/main'