Repository navigation
Apply Copilot review suggestions and fix workflow issues - #15
Merged
Merged
Conversation
- Remove '|| echo' that was masking push failures - Remove '|| true' from git fetch to catch fetch errors - Add git remote remove to avoid conflicts - Job will now properly fail when push fails
- Change docker-compose to build from local Dockerfile - Use local image names instead of Harbor registry - Add commented Harbor image option for production deployments - Enables local development without Harbor access
surrealwolf
force-pushed
the
harbor-registry-config
branch
from
January 10, 2026 23:08
89ec303 to
05d9e3b
Compare
surrealwolf
force-pushed
the
harbor-registry-config
branch
from
January 10, 2026 23:09
05d9e3b to
41c3e44
Compare
- Add condition to skip push-to-gitlab job on pull_request events - Only run on push events to main branch: github.event_name == 'push' && github.ref == 'refs/heads/main' - Add git pull before push to handle GitLab being ahead - Fixes non-fast-forward errors when PRs tried to push to GitLab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies Copilot review suggestions and fixes workflow issues:
Changes
Security Improvements
--password-stdinfor secure Harbor login--password-stdinfor docker-login (security)Best Practices
onlywithrules--forceflagDocumentation